From 446d19c4de2dff6fd941239a41c360c25a6ae1bf Mon Sep 17 00:00:00 2001 From: "Ryan C. Gordon" Date: Sat, 14 Jun 2014 23:31:23 -0400 Subject: [PATCH] Removed SDL_SYS_JoystickNeedsPolling(). It was simpler to just have the polling (actually: hotplug detection) functions return immediately if it's not an appropriate time to poll. Note that previously, if any joystick/controller was opened, we would poll every time anyhow, skipping this function. --- src/events/SDL_events.c | 15 +--- src/joystick/SDL_joystick.c | 12 --- src/joystick/SDL_joystick_c.h | 3 - src/joystick/SDL_sysjoystick.h | 3 - src/joystick/android/SDL_sysjoystick.c | 5 -- src/joystick/bsd/SDL_sysjoystick.c | 5 -- src/joystick/darwin/SDL_sysjoystick.c | 9 -- src/joystick/dummy/SDL_sysjoystick.c | 5 -- src/joystick/haiku/SDL_haikujoystick.cc | 5 -- src/joystick/iphoneos/SDL_sysjoystick.m | 5 -- src/joystick/linux/SDL_sysjoystick.c | 9 -- src/joystick/psp/SDL_sysjoystick.c | 5 -- src/joystick/windows/SDL_dxjoystick.c | 112 ++++++++++-------------- src/joystick/windows/SDL_mmjoystick.c | 5 -- src/joystick/winrt/SDL_xinputjoystick.c | 8 -- 15 files changed, 46 insertions(+), 160 deletions(-) diff --git a/src/events/SDL_events.c b/src/events/SDL_events.c index 28be2ed313f06..7cb4f0cb5cae2 100644 --- a/src/events/SDL_events.c +++ b/src/events/SDL_events.c @@ -83,19 +83,6 @@ static struct } SDL_EventQ = { NULL, SDL_TRUE }; -static SDL_INLINE SDL_bool -SDL_ShouldPollJoystick() -{ -#if !SDL_JOYSTICK_DISABLED - if ((!SDL_disabled_events[SDL_JOYAXISMOTION >> 8] || - SDL_JoystickEventState(SDL_QUERY)) && - SDL_PrivateJoystickNeedsPolling()) { - return SDL_TRUE; - } -#endif - return SDL_FALSE; -} - /* Public functions */ void @@ -403,7 +390,7 @@ SDL_PumpEvents(void) } #if !SDL_JOYSTICK_DISABLED /* Check for joystick state change */ - if (SDL_ShouldPollJoystick()) { + if ((!SDL_disabled_events[SDL_JOYAXISMOTION >> 8] || SDL_JoystickEventState(SDL_QUERY))) { SDL_JoystickUpdate(); } #endif diff --git a/src/joystick/SDL_joystick.c b/src/joystick/SDL_joystick.c index 062ece3335fd3..b9924f3b69111 100644 --- a/src/joystick/SDL_joystick.c +++ b/src/joystick/SDL_joystick.c @@ -736,18 +736,6 @@ SDL_JoystickEventState(int state) #endif /* SDL_EVENTS_DISABLED */ } -/* return 1 if you want to run the joystick update loop this frame, used by hotplug support */ -SDL_bool -SDL_PrivateJoystickNeedsPolling() -{ - if (SDL_joysticks != NULL) { - return SDL_TRUE; - } else { - return SDL_SYS_JoystickNeedsPolling(); - } -} - - /* return the guid for this index */ SDL_JoystickGUID SDL_JoystickGetDeviceGUID(int device_index) { diff --git a/src/joystick/SDL_joystick_c.h b/src/joystick/SDL_joystick_c.h index bb0c0205ae790..064fb8a39cc80 100644 --- a/src/joystick/SDL_joystick_c.h +++ b/src/joystick/SDL_joystick_c.h @@ -42,9 +42,6 @@ extern int SDL_PrivateJoystickHat(SDL_Joystick * joystick, extern int SDL_PrivateJoystickButton(SDL_Joystick * joystick, Uint8 button, Uint8 state); -/* Helper function to let lower sys layer tell the event system if the joystick code needs to think */ -extern SDL_bool SDL_PrivateJoystickNeedsPolling(); - /* Internal sanity checking functions */ extern int SDL_PrivateJoystickValid(SDL_Joystick * joystick); diff --git a/src/joystick/SDL_sysjoystick.h b/src/joystick/SDL_sysjoystick.h index 818509d678e5a..a5218d5078dc4 100644 --- a/src/joystick/SDL_sysjoystick.h +++ b/src/joystick/SDL_sysjoystick.h @@ -68,9 +68,6 @@ extern int SDL_SYS_NumJoysticks(); /* Function to cause any queued joystick insertions to be processed */ extern void SDL_SYS_JoystickDetect(); -/* Function to determine if the joystick loop needs to run right now */ -extern SDL_bool SDL_SYS_JoystickNeedsPolling(); - /* Function to get the device-dependent name of a joystick */ extern const char *SDL_SYS_JoystickNameForDeviceIndex(int device_index); diff --git a/src/joystick/android/SDL_sysjoystick.c b/src/joystick/android/SDL_sysjoystick.c index 422c5f5f4d0fc..cce94b80c5a9f 100644 --- a/src/joystick/android/SDL_sysjoystick.c +++ b/src/joystick/android/SDL_sysjoystick.c @@ -410,11 +410,6 @@ void SDL_SYS_JoystickDetect() } } -SDL_bool SDL_SYS_JoystickNeedsPolling() -{ - return SDL_TRUE; -} - static SDL_joylist_item * JoystickByDevIndex(int device_index) { diff --git a/src/joystick/bsd/SDL_sysjoystick.c b/src/joystick/bsd/SDL_sysjoystick.c index 2a09f923d3e1b..65a32ed2ebdba 100644 --- a/src/joystick/bsd/SDL_sysjoystick.c +++ b/src/joystick/bsd/SDL_sysjoystick.c @@ -213,11 +213,6 @@ void SDL_SYS_JoystickDetect() { } -SDL_bool SDL_SYS_JoystickNeedsPolling() -{ - return SDL_FALSE; -} - const char * SDL_SYS_JoystickNameForDeviceIndex(int device_index) { diff --git a/src/joystick/darwin/SDL_sysjoystick.c b/src/joystick/darwin/SDL_sysjoystick.c index bdb6d2939fa40..12c104820383e 100644 --- a/src/joystick/darwin/SDL_sysjoystick.c +++ b/src/joystick/darwin/SDL_sysjoystick.c @@ -601,15 +601,6 @@ SDL_SYS_JoystickDetect() } } -SDL_bool -SDL_SYS_JoystickNeedsPolling() -{ - while (CFRunLoopRunInMode(SDL_JOYSTICK_RUNLOOP_MODE,0,TRUE) == kCFRunLoopRunHandledSource) { - /* no-op. Pending callbacks will fire in CFRunLoopRunInMode(). */ - } - return s_bDeviceAdded || s_bDeviceRemoved; -} - /* Function to get the device-dependent name of a joystick */ const char * SDL_SYS_JoystickNameForDeviceIndex(int device_index) diff --git a/src/joystick/dummy/SDL_sysjoystick.c b/src/joystick/dummy/SDL_sysjoystick.c index 0d45b6ce290f6..9baa79500848f 100644 --- a/src/joystick/dummy/SDL_sysjoystick.c +++ b/src/joystick/dummy/SDL_sysjoystick.c @@ -46,11 +46,6 @@ void SDL_SYS_JoystickDetect() { } -SDL_bool SDL_SYS_JoystickNeedsPolling() -{ - return SDL_FALSE; -} - /* Function to get the device-dependent name of a joystick */ const char * SDL_SYS_JoystickNameForDeviceIndex(int device_index) diff --git a/src/joystick/haiku/SDL_haikujoystick.cc b/src/joystick/haiku/SDL_haikujoystick.cc index 95757bc1dfbba..0caea17f64872 100644 --- a/src/joystick/haiku/SDL_haikujoystick.cc +++ b/src/joystick/haiku/SDL_haikujoystick.cc @@ -94,11 +94,6 @@ extern "C" { } - SDL_bool SDL_SYS_JoystickNeedsPolling() - { - return SDL_FALSE; - } - /* Function to get the device-dependent name of a joystick */ const char *SDL_SYS_JoystickNameForDeviceIndex(int device_index) { diff --git a/src/joystick/iphoneos/SDL_sysjoystick.m b/src/joystick/iphoneos/SDL_sysjoystick.m index b89bd78ed7abd..a895130a5d5fa 100644 --- a/src/joystick/iphoneos/SDL_sysjoystick.m +++ b/src/joystick/iphoneos/SDL_sysjoystick.m @@ -49,11 +49,6 @@ void SDL_SYS_JoystickDetect() { } -SDL_bool SDL_SYS_JoystickNeedsPolling() -{ - return SDL_FALSE; -} - /* Function to get the device-dependent name of a joystick */ const char * SDL_SYS_JoystickNameForDeviceIndex(int device_index) diff --git a/src/joystick/linux/SDL_sysjoystick.c b/src/joystick/linux/SDL_sysjoystick.c index c37a22d58c867..05bf086f24812 100644 --- a/src/joystick/linux/SDL_sysjoystick.c +++ b/src/joystick/linux/SDL_sysjoystick.c @@ -392,15 +392,6 @@ void SDL_SYS_JoystickDetect() } -SDL_bool SDL_SYS_JoystickNeedsPolling() -{ -#if SDL_USE_LIBUDEV - return SDL_TRUE; -#endif - - return SDL_FALSE; -} - static SDL_joylist_item * JoystickByDevIndex(int device_index) { diff --git a/src/joystick/psp/SDL_sysjoystick.c b/src/joystick/psp/SDL_sysjoystick.c index d01489bb8cb16..9a2362e1d5902 100644 --- a/src/joystick/psp/SDL_sysjoystick.c +++ b/src/joystick/psp/SDL_sysjoystick.c @@ -141,11 +141,6 @@ void SDL_SYS_JoystickDetect() { } -SDL_bool SDL_SYS_JoystickNeedsPolling() -{ - return SDL_FALSE; -} - /* Function to get the device-dependent name of a joystick */ const char * SDL_SYS_JoystickNameForDeviceIndex(int device_index) { diff --git a/src/joystick/windows/SDL_dxjoystick.c b/src/joystick/windows/SDL_dxjoystick.c index 66c2e0f00e416..ff8a215e5e1e6 100644 --- a/src/joystick/windows/SDL_dxjoystick.c +++ b/src/joystick/windows/SDL_dxjoystick.c @@ -797,80 +797,71 @@ EnumXInputDevices(JoyStick_DeviceData **pContext) void SDL_SYS_JoystickDetect() { JoyStick_DeviceData *pCurList = NULL; +#if !SDL_EVENTS_DISABLED + SDL_Event event; +#endif + /* only enum the devices if the joystick thread told us something changed */ - if ( s_bDeviceAdded || s_bDeviceRemoved ) - { - SDL_LockMutex( s_mutexJoyStickEnum ); + if (!s_bDeviceAdded && !s_bDeviceRemoved) { + return; /* thread hasn't signaled, nothing to do right now. */ + } - s_bDeviceAdded = SDL_FALSE; - s_bDeviceRemoved = SDL_FALSE; + SDL_LockMutex(s_mutexJoyStickEnum); - pCurList = SYS_Joystick; - SYS_Joystick = NULL; + s_bDeviceAdded = SDL_FALSE; + s_bDeviceRemoved = SDL_FALSE; - /* Look for DirectInput joysticks, wheels, head trackers, gamepads, etc.. */ - IDirectInput8_EnumDevices(dinput, - DI8DEVCLASS_GAMECTRL, - EnumJoysticksCallback, - &pCurList, DIEDFL_ATTACHEDONLY); + pCurList = SYS_Joystick; + SYS_Joystick = NULL; - SDL_free(SDL_RawDevList); /* in case we used this in DirectInput enumerator. */ - SDL_RawDevList = NULL; - SDL_RawDevListCount = 0; + /* Look for DirectInput joysticks, wheels, head trackers, gamepads, etc.. */ + IDirectInput8_EnumDevices(dinput, DI8DEVCLASS_GAMECTRL, EnumJoysticksCallback, &pCurList, DIEDFL_ATTACHEDONLY); - /* Look for XInput devices. Do this last, so they're first in the final list. */ - EnumXInputDevices(&pCurList); + SDL_free(SDL_RawDevList); /* in case we used this in DirectInput enumerator. */ + SDL_RawDevList = NULL; + SDL_RawDevListCount = 0; - SDL_UnlockMutex( s_mutexJoyStickEnum ); - } + /* Look for XInput devices. Do this last, so they're first in the final list. */ + EnumXInputDevices(&pCurList); - if ( pCurList ) - { - while ( pCurList ) - { - JoyStick_DeviceData *pListNext = NULL; + SDL_UnlockMutex(s_mutexJoyStickEnum); + + while (pCurList) { + JoyStick_DeviceData *pListNext = NULL; #if SDL_HAPTIC_DINPUT - if (pCurList->bXInputDevice) { - XInputHaptic_MaybeRemoveDevice(pCurList->XInputUserId); - } else { - DirectInputHaptic_MaybeRemoveDevice(&pCurList->dxdevice); - } + if (pCurList->bXInputDevice) { + XInputHaptic_MaybeRemoveDevice(pCurList->XInputUserId); + } else { + DirectInputHaptic_MaybeRemoveDevice(&pCurList->dxdevice); + } #endif #if !SDL_EVENTS_DISABLED - { - SDL_Event event; - event.type = SDL_JOYDEVICEREMOVED; + SDL_zero(event); + event.type = SDL_JOYDEVICEREMOVED; - if (SDL_GetEventState(event.type) == SDL_ENABLE) { - event.jdevice.which = pCurList->nInstanceID; - if ((SDL_EventOK == NULL) - || (*SDL_EventOK) (SDL_EventOKParam, &event)) { - SDL_PushEvent(&event); - } - } + if (SDL_GetEventState(event.type) == SDL_ENABLE) { + event.jdevice.which = pCurList->nInstanceID; + if ((!SDL_EventOK) || (*SDL_EventOK) (SDL_EventOKParam, &event)) { + SDL_PushEvent(&event); } -#endif /* !SDL_EVENTS_DISABLED */ - - pListNext = pCurList->pNext; - SDL_free(pCurList->joystickname); - SDL_free(pCurList); - pCurList = pListNext; } +#endif /* !SDL_EVENTS_DISABLED */ + pListNext = pCurList->pNext; + SDL_free(pCurList->joystickname); + SDL_free(pCurList); + pCurList = pListNext; } - if ( s_bDeviceAdded ) - { + if (s_bDeviceAdded) { JoyStick_DeviceData *pNewJoystick; int device_index = 0; s_bDeviceAdded = SDL_FALSE; pNewJoystick = SYS_Joystick; - while ( pNewJoystick ) - { - if ( pNewJoystick->send_add_event ) - { + while (pNewJoystick) { + if (pNewJoystick->send_add_event) { #if SDL_HAPTIC_DINPUT if (pNewJoystick->bXInputDevice) { XInputHaptic_MaybeAddDevice(pNewJoystick->XInputUserId); @@ -880,18 +871,15 @@ void SDL_SYS_JoystickDetect() #endif #if !SDL_EVENTS_DISABLED - { - SDL_Event event; + SDL_zero(event); event.type = SDL_JOYDEVICEADDED; if (SDL_GetEventState(event.type) == SDL_ENABLE) { event.jdevice.which = device_index; - if ((SDL_EventOK == NULL) - || (*SDL_EventOK) (SDL_EventOKParam, &event)) { - SDL_PushEvent(&event); + if ((!SDL_EventOK) || (*SDL_EventOK) (SDL_EventOKParam, &event)) { + SDL_PushEvent(&event); } } - } #endif /* !SDL_EVENTS_DISABLED */ pNewJoystick->send_add_event = 0; } @@ -901,16 +889,6 @@ void SDL_SYS_JoystickDetect() } } -/* we need to poll if we have pending hotplug device changes or connected devices */ -SDL_bool SDL_SYS_JoystickNeedsPolling() -{ - /* we have a new device or one was pulled, we need to think this frame please */ - if ( s_bDeviceAdded || s_bDeviceRemoved ) - return SDL_TRUE; - - return SDL_FALSE; -} - /* Function to get the device-dependent name of a joystick */ const char * SDL_SYS_JoystickNameForDeviceIndex(int device_index) diff --git a/src/joystick/windows/SDL_mmjoystick.c b/src/joystick/windows/SDL_mmjoystick.c index c28ed91b528aa..0f3b6deccaf08 100644 --- a/src/joystick/windows/SDL_mmjoystick.c +++ b/src/joystick/windows/SDL_mmjoystick.c @@ -193,11 +193,6 @@ void SDL_SYS_JoystickDetect() { } -SDL_bool SDL_SYS_JoystickNeedsPolling() -{ - return SDL_FALSE; -} - /* Function to get the device-dependent name of a joystick */ const char * SDL_SYS_JoystickNameForDeviceIndex(int device_index) diff --git a/src/joystick/winrt/SDL_xinputjoystick.c b/src/joystick/winrt/SDL_xinputjoystick.c index 00005080f337b..63e694c539052 100644 --- a/src/joystick/winrt/SDL_xinputjoystick.c +++ b/src/joystick/winrt/SDL_xinputjoystick.c @@ -230,14 +230,6 @@ void SDL_SYS_JoystickDetect() SDL_UnlockMutex(g_DeviceInfoLock); } -SDL_bool SDL_SYS_JoystickNeedsPolling() -{ - /* Since XInput, or WinRT, provides any events to indicate when a game - controller gets connected, and instead indicates device availability - solely through polling, we'll poll (for new devices). - */ - return SDL_TRUE; -} /* Internal function to retreive device capabilities. This function will return an SDL-standard value of 0 on success