From 73680ab3740392904a72309ccf3d7a6757a049cb Mon Sep 17 00:00:00 2001 From: "Ryan C. Gordon" Date: Thu, 7 Jan 2016 16:01:24 -0500 Subject: [PATCH] Fixed NULL dereference on drop events with no window associated. (such as when dropping a file onto an app's icon to launch.) This bug caught by Clang's static analyzer. --- src/events/SDL_dropevents.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/events/SDL_dropevents.c b/src/events/SDL_dropevents.c index ba4dcd6b059d0..49b07d9a65fd8 100644 --- a/src/events/SDL_dropevents.c +++ b/src/events/SDL_dropevents.c @@ -43,7 +43,11 @@ SDL_SendDrop(SDL_Window *window, const SDL_EventType evtype, const char *data) if (need_begin) { SDL_zero(event); event.type = SDL_DROPBEGIN; - event.drop.windowID = window->id; + + if (window) { + event.drop.windowID = window->id; + } + posted = (SDL_PushEvent(&event) > 0); if (!posted) { return 0;