From f3e609679dd797762e4a9c125f9cded11ac35f12 Mon Sep 17 00:00:00 2001 From: Sam Lantinga Date: Thu, 2 Apr 2020 12:27:29 -0700 Subject: [PATCH] Fixed setting the "playandrecord" audio hint on Apple TV The Apple TV doesn't have record capability by default, so activating the audio session with AVAudioSessionCategoryPlayAndRecord fails. --- src/audio/coreaudio/SDL_coreaudio.m | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/audio/coreaudio/SDL_coreaudio.m b/src/audio/coreaudio/SDL_coreaudio.m index 2fdaac77a54d3..676072f379a1c 100644 --- a/src/audio/coreaudio/SDL_coreaudio.m +++ b/src/audio/coreaudio/SDL_coreaudio.m @@ -331,7 +331,7 @@ - (void)applicationBecameActive:(NSNotification *)note @end -static BOOL update_audio_session(_THIS, SDL_bool open) +static BOOL update_audio_session(_THIS, SDL_bool open, SDL_bool allow_playandrecord) { @autoreleasepool { AVAudioSession *session = [AVAudioSession sharedInstance]; @@ -356,7 +356,9 @@ static BOOL update_audio_session(_THIS, SDL_bool open) options &= ~AVAudioSessionCategoryOptionMixWithOthers; } else if (SDL_strcasecmp(hint, "AVAudioSessionCategoryPlayAndRecord") == 0 || SDL_strcasecmp(hint, "playandrecord") == 0) { - category = AVAudioSessionCategoryPlayAndRecord; + if (allow_playandrecord) { + category = AVAudioSessionCategoryPlayAndRecord; + } } } else if (open_playback_devices && open_capture_devices) { category = AVAudioSessionCategoryPlayAndRecord; @@ -390,6 +392,11 @@ static BOOL update_audio_session(_THIS, SDL_bool open) if (open && (open_playback_devices + open_capture_devices) == 1) { if (![session setActive:YES error:&err]) { + if ([err code] == AVAudioSessionErrorCodeResourceNotAvailable && + category == AVAudioSessionCategoryPlayAndRecord) { + return update_audio_session(this, open, SDL_FALSE); + } + NSString *desc = err.description; SDL_SetError("Could not activate Audio Session: %s", desc.UTF8String); return NO; @@ -620,7 +627,7 @@ static BOOL update_audio_session(_THIS, SDL_bool open) } #if !MACOSX_COREAUDIO - update_audio_session(this, SDL_FALSE); + update_audio_session(this, SDL_FALSE, SDL_TRUE); #endif /* if callback fires again, feed silence; don't call into the app. */ @@ -945,7 +952,7 @@ output device (in which case we'll try again). */ } #if !MACOSX_COREAUDIO - if (!update_audio_session(this, SDL_TRUE)) { + if (!update_audio_session(this, SDL_TRUE, SDL_TRUE)) { return -1; }