From 444e5b2dac407ab6c561c2230b97c240a6af13fb Mon Sep 17 00:00:00 2001 From: Sam Lantinga Date: Sun, 30 Jan 2011 13:38:57 -0800 Subject: [PATCH] Fixed bug #1111 kwm@rainbow-runner.nl 2011-01-30 06:28:27 PST When building sdl 1.2.14 with the Clang compiler http://clang.llvm.org . The build fails in src/video/mmx.h with the following error: -------------------------------------------------- ./src/video/SDL_RLEaccel.c:831:5: error: invalid operand for instruction CHOOSE_BLIT(RLECLIPBLIT, alpha, fmt); ^ ./src/video/SDL_RLEaccel.c:831:17: note: instantiated from: CHOOSE_BLIT(RLECLIPBLIT, alpha, fmt); ^ ./src/video/SDL_RLEaccel.c:831:5: note: instantiated from: CHOOSE_BLIT(RLECLIPBLIT, alpha, fmt); ^ ./src/video/SDL_RLEaccel.c:647:23: note: instantiated from: blitter(2, Uint8, ALPHA_BLIT16_565MMX); \ ^ ./src/video/SDL_RLEaccel.c:282:4: note: instantiated from: movq_r2m(mm3, *dstp); \ ^ In file included from ./src/video/SDL_RLEaccel.c:99: ./src/video/mmx.h:379:28: note: instantiated from: #define movq_r2m(reg, var) mmx_r2m(movq, reg, var) ^ :192:1: note: instantiated from: "movq" ^ :1:2: note: instantiated into assembly here movq %mm3, %dx ^ -------------------------------------------------- According to the clang developers this is a invalid inline assembly. Using the attached patch from the last commit in the below bug report fixes the compile. More details from: http://llvm.org/bugs/show_bug.cgi?id=6730 --- src/video/mmx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/video/mmx.h b/src/video/mmx.h index 396c4326c..2ab9fe396 100644 --- a/src/video/mmx.h +++ b/src/video/mmx.h @@ -355,7 +355,7 @@ mmx_ok(void) #define mmx_r2m(op, reg, mem) \ __asm__ __volatile__ (#op " %%" #reg ", %0" \ - : "=X" (mem) \ + : "=m" (mem) \ : /* nothing */ ) #define mmx_r2r(op, regs, regd) \