From d375db16b5986f6cd70609e91ad86020b733dca3 Mon Sep 17 00:00:00 2001 From: Sam Lantinga Date: Sun, 16 May 2004 17:40:32 +0000 Subject: [PATCH] Date: Sun, 28 Mar 2004 16:38:32 +1200 From: Paul Eggleton Subject: [SDL] Possible memory leak in SDL 1.2.7 Taking a look at this function X11_CreateWMCursor and its companion X11_FreeWMCursor (in src/video/x11/SDL_x11mouse.c), I can see that X11_CreateWMCursor is making several calls to XCreatePixmap, but there are no corresponding calls in X11_FreeWMCursor to XFreePixmap. --- src/video/x11/SDL_x11mouse.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/video/x11/SDL_x11mouse.c b/src/video/x11/SDL_x11mouse.c index 1adcedae6..df7e26463 100644 --- a/src/video/x11/SDL_x11mouse.c +++ b/src/video/x11/SDL_x11mouse.c @@ -142,6 +142,8 @@ WMcursor *X11_CreateWMCursor(_THIS, /* Create the cursor */ cursor->x_cursor = XCreatePixmapCursor(SDL_Display, data_pixmap, mask_pixmap, &black, &white, hot_x, hot_y); + XFreePixmap(SDL_Display, data_pixmap); + XFreePixmap(SDL_Display, mask_pixmap); /* Release the event thread */ XSync(SDL_Display, False);