Mon, 01 May 2006 11:07:04 +0000Using the SDL C runtime functions
Sam Lantinga <slouken@libsdl.org> [Mon, 01 May 2006 11:07:04 +0000] rev 1756
Using the SDL C runtime functions

Mon, 01 May 2006 07:23:46 +0000Don't add NONE/bin to the path - inexplicably fixes building on mingw+msys, apparently
Sam Lantinga <slouken@libsdl.org> [Mon, 01 May 2006 07:23:46 +0000] rev 1755
Don't add NONE/bin to the path - inexplicably fixes building on mingw+msys, apparently

Mon, 01 May 2006 07:15:35 +0000Date: Sun, 30 Apr 2006 14:20:05 +1000
Sam Lantinga <slouken@libsdl.org> [Mon, 01 May 2006 07:15:35 +0000] rev 1754
Date: Sun, 30 Apr 2006 14:20:05 +1000
From: Rob
Subject: [SDL] SDL pre-release

OpenGL fails on the zipped pre-release source accessible from
http://www.libsdl.org/svn.php.

Appears to be following lines in sdl_wing.c (lines 341-345):

wglext = (const char *)this->glGetString(GL_EXTENSIONS);
if ( !SDL_strstr(wglext, "WGL_EXT_swap_control") ) {
this->gl_data->wglSwapIntervalEXT = NULL;
this->gl_data->wglGetSwapIntervalEXT = NULL;
}

glGetString is a null pointer, as are other gl function pointers, so call
fails. Never looked at sdl source before, so no further than that as yet.

Mon, 01 May 2006 06:41:17 +0000SDL_dummy_main.c:12: warning: ISO C does not allow extra â;â outside of a function
Sam Lantinga <slouken@libsdl.org> [Mon, 01 May 2006 06:41:17 +0000] rev 1753
SDL_dummy_main.c:12: warning: ISO C does not allow extra â;â outside of a function

Mon, 01 May 2006 06:40:00 +0000SDL_sysjoystick.c:983: warning: 'return' with a value, in function returning void
Sam Lantinga <slouken@libsdl.org> [Mon, 01 May 2006 06:40:00 +0000] rev 1752
SDL_sysjoystick.c:983: warning: 'return' with a value, in function returning void

Sun, 30 Apr 2006 21:01:25 +0000Declare volatile variables modified by interrupt routines
Patrice Mandin <patmandin@gmail.com> [Sun, 30 Apr 2006 21:01:25 +0000] rev 1751
Declare volatile variables modified by interrupt routines

Sun, 30 Apr 2006 16:53:40 +0000Removed redundant rm
Sam Lantinga <slouken@libsdl.org> [Sun, 30 Apr 2006 16:53:40 +0000] rev 1750
Removed redundant rm

Sun, 30 Apr 2006 08:57:02 +0000We want to wrap HAVE_ALLOCA_H, not HAVE_ALLOCA. :)
Sam Lantinga <slouken@libsdl.org> [Sun, 30 Apr 2006 08:57:02 +0000] rev 1749
We want to wrap HAVE_ALLOCA_H, not HAVE_ALLOCA. :)

Sat, 29 Apr 2006 20:22:31 +0000------- Comment #1 From Max Horn 2006-04-17 03:08 [reply] -------
Sam Lantinga <slouken@libsdl.org> [Sat, 29 Apr 2006 20:22:31 +0000] rev 1748
------- Comment #1 From Max Horn 2006-04-17 03:08 [reply] -------

Created an attachment (id=106) [edit]
Patch for src/joystick/win32/SDL_mmjoystick.c

I am not even a Windows user, so take the following with a grain of salt:

SDL_mmjoystick.c has a function GetJoystickName which obtains the joystick
name by looking at the registry. The way it does that seems very fishy to me.
Namely, it uses the parameter "index" to construct a registry value name (BTW,
those variables used in the code are really badly named). The value of "index"
in turn equals the current value of "numdevs", as called from
SDL_SYS_JoystickInit.

I read through the MSDN docs at
<http://msdn.microsoft.com/archive/default.asp?url=/archive/en-us/dnarinput/html/msdn_extdirect.asp>,
and I believe the simple fix is to replace line 183 of said file
SYS_JoystickName[numdevs] = GetJoystickName(numdevs, joycaps.szRegKey);
by the following:
SYS_JoystickName[numdevs] = GetJoystickName(SYS_JoystickID[i],
joycaps.szRegKey);

However, that is only *hiding* the real issue. Problem is, the list of
joysticks as returned by windows may contains "gaps", and the code deals
incorrectly with that. Namely those gaps occur if joysticks are
removed/(re)added, as the reporter observed.

The attached patch fixes this and another (off-by-one) issue in the code. But
since I have no Windows machine, I can't even test-compile it, so use with
caution.

Sat, 29 Apr 2006 17:56:06 +0000(none)
Sam Lantinga <slouken@libsdl.org> [Sat, 29 Apr 2006 17:56:06 +0000] rev 1747
(none)