Mon, 10 Jun 2019 08:46:20 -0700Fixed bug 4641 - clang and clang-cl builds on windows create -Wpragma-pack warnings
Sam Lantinga <slouken@libsdl.org> [Mon, 10 Jun 2019 08:46:20 -0700] rev 12813
Fixed bug 4641 - clang and clang-cl builds on windows create -Wpragma-pack warnings

Sun, 09 Jun 2019 19:27:25 -0400cocoa: report proper input IDs for mouse/touch events.
Ryan C. Gordon <icculus@icculus.org> [Sun, 09 Jun 2019 19:27:25 -0400] rev 12812
cocoa: report proper input IDs for mouse/touch events.

Otherwise, we generate incorrect mouse events for MacBook trackpads (which
are also multitouch devices), etc.

Partially fixes Bugzilla #4576.

Sun, 09 Jun 2019 14:08:18 -0700Fixed bug 4658 - iOS 12 fullscreen flag and SDL_HINT_IOS_HIDE_HOME_INDICATOR not working
Sam Lantinga <slouken@libsdl.org> [Sun, 09 Jun 2019 14:08:18 -0700] rev 12811
Fixed bug 4658 - iOS 12 fullscreen flag and SDL_HINT_IOS_HIDE_HOME_INDICATOR not working

Caleb Cornett

On iOS 12, creating a window with the SDL_WINDOW_FULLSCREEN flag does not dim the home indicator or defer system gestures. The same goes for setting the SDL_HINT_IOS_HIDE_HOME_INDICATOR to "2" -- it has no effect at all.

I've tracked down the source of this misbehavior to a timing issue. The initial `setNeedsUpdate...` calls were happening too early and getting applied to the launch screen by mistake. In the attached patch, I've added a call to those functions right after the launch screen is hidden so that they apply to the main view controller instead. This appears to fix the issue, at least on my iPhone 6s Plus.

Sun, 09 Jun 2019 11:54:51 -0400Add notes for SDL_WinRTRunApp and SDL2-WinRTResources for non-C++ projects
Ethan Lee <flibitijibibo@flibitijibibo.com> [Sun, 09 Jun 2019 11:54:51 -0400] rev 12810
Add notes for SDL_WinRTRunApp and SDL2-WinRTResources for non-C++ projects

Sun, 09 Jun 2019 12:46:10 -0700Cleanup on bug 3894 - Fuzzing crashes for SDL_LoadWAV
Sam Lantinga <slouken@libsdl.org> [Sun, 09 Jun 2019 12:46:10 -0700] rev 12809
Cleanup on bug 3894 - Fuzzing crashes for SDL_LoadWAV

Simon Hug

Attached is a minor cleanup patch. It changes the option name of one hint to something better, puts one or two more checks in, and adds explicit casting where warnings could appear otherwise.

I hope the naming of the hints and their options is acceptable. It would be kind of awkward to change them after they get released with an official SDL version.

Sat, 08 Jun 2019 19:12:05 -0700Fixed compiler warning
Sam Lantinga <slouken@libsdl.org> [Sat, 08 Jun 2019 19:12:05 -0700] rev 12808
Fixed compiler warning
warning C4018: '<' : signed/unsigned mismatch

Sat, 08 Jun 2019 19:09:43 -0700Fixed build
Sam Lantinga <slouken@libsdl.org> [Sat, 08 Jun 2019 19:09:43 -0700] rev 12807
Fixed build

Sat, 08 Jun 2019 19:02:42 -0700Fixed bug 3894 - Fuzzing crashes for SDL_LoadWAV
Sam Lantinga <slouken@libsdl.org> [Sat, 08 Jun 2019 19:02:42 -0700] rev 12806
Fixed bug 3894 - Fuzzing crashes for SDL_LoadWAV

Simon Hug

I had a look at this and made some additions to SDL_wave.c.

The attached patch adds many checks and error messages. For some reason I also added A-law and ยต-law decoders. Forgot exactly why... but hey, they're small.

The WAVE format is seriously underspecified (at least by the documents that are publicly available on the internet) and it's a shame Microsoft never put something better out there. The language used in them is so loose at times, it's not surprising the encoders and decoders behave very differently. The Windows Media Player doesn't even support MS ADPCM correctly.

The patch also adds some hints to make the decoder more strict at the cost of compatibility with weird WAVE files.

I still think it needs a bit of cleaning up (Not happy with the MultiplySize function. Don't like the name and other SDL code may want to use something like this too.) and some duplicated code may be folded together. It does work in this state and I have thrown all kinds of WAVE files at it. The AFL files also pass with it and some even play (obviously just noise). Crafty little fuzzer.

Any critique would be welcome. I have a fork of SDL with a audio-loadwav branch over here if someone wants to use the commenting feature of Bitbucket:

https://bitbucket.org/ChliHug/SDL

I also cobbled some Lua scripts together to create WAVE test files:

https://bitbucket.org/ChliHug/gendat

Sat, 08 Jun 2019 18:40:11 -0700Fixed bug 4041 - Android, SDL_Renderer OpenGLES 1 is loading GLESv2 library
Sam Lantinga <slouken@libsdl.org> [Sat, 08 Jun 2019 18:40:11 -0700] rev 12805
Fixed bug 4041 - Android, SDL_Renderer OpenGLES 1 is loading GLESv2 library

Sylvain

On Android, if you set no attribute using SDL_GL_SetAttribute(), and try to create a SDL Render OpenGLES 1:

- it loads first by default GLESv2 libraries
- creates the rendere OpenGLES 1
- recreates the Window to have a context 1.1 ( https://hg.libsdl.org/SDL/file/00fb5966c44f/src/render/opengles/SDL_render_gles.c#l298 )

But it doesn't unload libraries, then reload GLESv1 lib. So the SDL_Renderer OpenGLES 1 is working with GLES 2 libs, which seems inconsistent.


If you, at first, set
SDL_GL_SetAttribute(SDL_GL_CONTEXT_PROFILE_MASK, SDL_GL_CONTEXT_PROFILE_ES);
SDL_GL_SetAttribute(SDL_GL_CONTEXT_MAJOR_VERSION, 1);
SDL_GL_SetAttribute(SDL_GL_CONTEXT_MINOR_VERSION, 1);
It will correctly load GLES v1 libraries.

Here's a small patch to reload egl libs when SDL_RecreateWindow() is called.
It fixes the issue, also the case from bug 4042

( SDL_RecreateWindow() is used by SDL_Renderer gl, gles1, gles2. )

Sat, 08 Jun 2019 18:32:29 -0700Temporary fix for bug 4254 - a _lot_ of strict aliasing warnings
Sam Lantinga <slouken@libsdl.org> [Sat, 08 Jun 2019 18:32:29 -0700] rev 12804
Temporary fix for bug 4254 - a _lot_ of strict aliasing warnings

Ozkan Sezer

A horde of strict aliasing violation warnings are emitted from joystick
layer, and also from a few other places. This happens with gcc-4.4.7 on
Linux CentOS 6.10. Some other sysjoystick would possibly have the same
warnings.

Attached my full log here. Example entry:
src/joystick/SDL_joystick.c: In function 'SDL_GetJoystickGUIDInfo':
src/joystick/SDL_joystick.c:1094: warning: dereferencing pointer '({anonymous})' does break strict-aliasing rules