Mon, 17 Oct 2016 22:09:22 -0700Fixed bug 3444 - Android-TV: no more handling of back button on remote
Sam Lantinga <slouken@libsdl.org> [Mon, 17 Oct 2016 22:09:22 -0700] rev 10551
Fixed bug 3444 - Android-TV: no more handling of back button on remote

ny00

Unfortunately, simply checking the return codes of "onNativePadDown/Up" as previously done has its own issue:

If an SDL joystick is connected *and* opened, then a proper KeyEvent, say with keycode KEYCODE_BUTTON_1, should lead to an SDL joystick button event as expected.

If, however, the joystick was *not* opened, then "onNativePadDown/Up" will return a negative value, so before the commit from bug 3426, you could unexpectedly get a keyboard event. (In practice, you'll just get a log message, since KEYCODE_BUTTON_1 has no mapping to a proper SDL_ScanCode value, but it's still an problem).

What should still be done, though, is checking the key code itself. We do have the KeyEvent.isGamepadButton method, but according my test, it returns "true" exactly (and only) for the KEYCODE_BUTTON* values, and not for KEYCODE_DPAD* or any other key code.

Here is a possible solution:
- Do check the return codes of "onNativePadDown/Up" as previously done.
- In addition, in "Android_OnPadDown/Up" from src/joystick/android/SDL_sysjoystick.c, 0 should *always* be returned in case the key code can be translated to an SDL_joystick button; Even if no matching joystick can be found.

Mon, 17 Oct 2016 21:47:33 -0700Partial fix for bug 3092 - Statically link sdl2 with /MT for msvc
Sam Lantinga <slouken@libsdl.org> [Mon, 17 Oct 2016 21:47:33 -0700] rev 10550
Partial fix for bug 3092 - Statically link sdl2 with /MT for msvc

Mike Linford

I'm also having trouble statically linking SDL2 on Visual Studio 2015 with /MT. My symptom is that memcpy is being defined twice.

Mon, 17 Oct 2016 21:44:32 -0700Fixed bug 3456 - SDL_GameControllerOpen fails if the joystick subsystem isn't initialized
Sam Lantinga <slouken@libsdl.org> [Mon, 17 Oct 2016 21:44:32 -0700] rev 10549
Fixed bug 3456 - SDL_GameControllerOpen fails if the joystick subsystem isn't initialized

Philipp Wiesemann

Maybe the fault is in the SDL_VIDEO_DRIVER_WINDOWS section in SDL_InitSubSystem() of "src/SDL.c". Because there only SDL_INIT_JOYSTICK is checked. The flags are adapted for SDL_INIT_GAMECONTROLLER afterwards.

Mon, 17 Oct 2016 21:37:26 -0700Fixed bug 3458 - x11: reset deadkeys in StartTextInput/StopTextInput
Sam Lantinga <slouken@libsdl.org> [Mon, 17 Oct 2016 21:37:26 -0700] rev 10548
Fixed bug 3458 - x11: reset deadkeys in StartTextInput/StopTextInput

Eric Wasylishen

The patch makes StartTextInput/StopTextInput call Xutf8ResetIC ( https://www.x.org/releases/X11R7.5/doc/man/man3/XmbResetIC.3.html ) on the XIC of all SDL windows.

This fixes my use case in Quakespasm (Ubuntu 16.04, system keyboard layout set to German. Type the '^' dead key, which opens Quakespasm's developer console and calls SDL_StartTextInput, then press 'e'. I expect the dead key to be ignored.)

Also, here is a patch for sdl2's "checkkeys" for testing this: https://bugzilla-attachments.libsdl.org/attachment.cgi?id=2451

Sun, 16 Oct 2016 22:47:49 +0200Linux: Added missing scancodes.
Philipp Wiesemann <philipp.wiesemann@arcor.de> [Sun, 16 Oct 2016 22:47:49 +0200] rev 10547
Linux: Added missing scancodes.

Sun, 16 Oct 2016 22:47:37 +0200Windows: Fixed not removing the always added hint callback on quit.
Philipp Wiesemann <philipp.wiesemann@arcor.de> [Sun, 16 Oct 2016 22:47:37 +0200] rev 10546
Windows: Fixed not removing the always added hint callback on quit.

This was no real problem because SDL_Quit() also calls SDL_ClearHints().

Sun, 16 Oct 2016 22:46:56 +0200Linux: Removed not needed platform info from entry in controller database.
Philipp Wiesemann <philipp.wiesemann@arcor.de> [Sun, 16 Oct 2016 22:46:56 +0200] rev 10545
Linux: Removed not needed platform info from entry in controller database.

Sat, 15 Oct 2016 20:02:17 +0200Linux: Fixed compile warnings about unused variables.
Philipp Wiesemann <philipp.wiesemann@arcor.de> [Sat, 15 Oct 2016 20:02:17 +0200] rev 10544
Linux: Fixed compile warnings about unused variables.

Sat, 15 Oct 2016 20:01:50 +0200Android: Split long line in README.
Philipp Wiesemann <philipp.wiesemann@arcor.de> [Sat, 15 Oct 2016 20:01:50 +0200] rev 10543
Android: Split long line in README.

Sat, 15 Oct 2016 20:01:30 +0200Removed unused constants in controllermap program.
Philipp Wiesemann <philipp.wiesemann@arcor.de> [Sat, 15 Oct 2016 20:01:30 +0200] rev 10542
Removed unused constants in controllermap program.