Thu, 20 Mar 2014 16:56:37 -0400Static analysis fix: Removed unused variable.
Ryan C. Gordon [Thu, 20 Mar 2014 16:56:37 -0400] rev 8657
Static analysis fix: Removed unused variable.

(We don't care if closing the device fails anyhow).

Thu, 20 Mar 2014 16:54:20 -0400Static analysis fix: uninitialized data.
Ryan C. Gordon [Thu, 20 Mar 2014 16:54:20 -0400] rev 8656
Static analysis fix: uninitialized data.

(This is Clang not knowing that SDL_SetError() always returns -1.)

Thu, 20 Mar 2014 16:25:30 -0400Static analysis fix: uninitialized data.
Ryan C. Gordon [Thu, 20 Mar 2014 16:25:30 -0400] rev 8655
Static analysis fix: uninitialized data.

(Clang doesn't know that "_this" was already checked for NULLness elsewhere.)

Thu, 20 Mar 2014 16:23:18 -0400Static analysis fix: uninitialized value.
Ryan C. Gordon [Thu, 20 Mar 2014 16:23:18 -0400] rev 8654
Static analysis fix: uninitialized value.

(A false positive: clang doesn't know SDL_SetError() always returns -1.)

Thu, 20 Mar 2014 16:05:57 -0400Static analysis fix: leaking Objective-C object.
Ryan C. Gordon [Thu, 20 Mar 2014 16:05:57 -0400] rev 8653
Static analysis fix: leaking Objective-C object.

Thu, 20 Mar 2014 11:22:57 -0400Static analysis fix: dereference of a NULL pointer.
Ryan C. Gordon [Thu, 20 Mar 2014 11:22:57 -0400] rev 8652
Static analysis fix: dereference of a NULL pointer.

Thu, 20 Mar 2014 11:14:02 -0400Static analysis fix: let clang know _this->displays isn't NULL.
Ryan C. Gordon [Thu, 20 Mar 2014 11:14:02 -0400] rev 8651
Static analysis fix: let clang know _this->displays isn't NULL.

Thu, 20 Mar 2014 11:14:44 -0400Static analysis fix: division by zero.
Ryan C. Gordon [Thu, 20 Mar 2014 11:14:44 -0400] rev 8650
Static analysis fix: division by zero.

Thu, 20 Mar 2014 10:41:47 -0400Static analysis fix: uninitialized variables.
Ryan C. Gordon [Thu, 20 Mar 2014 10:41:47 -0400] rev 8649
Static analysis fix: uninitialized variables.

This is actually a false-positive, in this case, since Clang doesn't know
that SDL_SetError() only ever returns -1. Feature request to improve that,
with explanation about these specific SDL patches, is here:

http://llvm.org/bugs/show_bug.cgi?id=19208

Thu, 20 Mar 2014 10:04:23 -0400Static analysis fix: Fixed leaking Objective-C object.
Ryan C. Gordon [Thu, 20 Mar 2014 10:04:23 -0400] rev 8648
Static analysis fix: Fixed leaking Objective-C object.