Thu, 28 May 2015 08:51:59 -0700Fixed Windows build
Sam Lantinga <slouken@libsdl.org> [Thu, 28 May 2015 08:51:59 -0700] rev 9665
Fixed Windows build

Thu, 28 May 2015 08:41:07 -0700Fixed bug 2860 - SetProp must be paired with RemoveProp especially for properties added to external windows
Sam Lantinga <slouken@libsdl.org> [Thu, 28 May 2015 08:41:07 -0700] rev 9664
Fixed bug 2860 - SetProp must be paired with RemoveProp especially for properties added to external windows

Coriiander

Upon creating a window, a window property is added to it through the Win32-function "SetProp". This is done in the SDL-function "SetupWindowData" in file "src\video\windows\SDL_windowswindow.c".

Whenever you call "SetProp" to add a property to a Win32-window, you should also call the Win32-function "RemoveProp" to remove it before destroying that Win32-window.

While you might think that it's ok and that Windows will clean up nicely itself, it is not ok. It is against all Win32-API guidelines and is mostlikely a leak. Especially on external windows (CreateWindowFrom) you want to have things done right, not messy and leaky, affecting some other module. Even if SDL gets shutdown entirely that external window will now forever still have the "SDL_WindowData" prop attached to it.

Thu, 28 May 2015 01:27:24 -0400I think this will be the time...
Ryan C. Gordon <icculus@icculus.org> [Thu, 28 May 2015 01:27:24 -0400] rev 9663
I think this will be the time...

Thu, 28 May 2015 01:22:14 -0400Still trying to get this to compile...
Ryan C. Gordon <icculus@icculus.org> [Thu, 28 May 2015 01:22:14 -0400] rev 9662
Still trying to get this to compile...

Thu, 28 May 2015 01:16:55 -0400More patching to compile...
Ryan C. Gordon <icculus@icculus.org> [Thu, 28 May 2015 01:16:55 -0400] rev 9661
More patching to compile...

Thu, 28 May 2015 01:08:33 -0400Another attempt to get this to compile.
Ryan C. Gordon <icculus@icculus.org> [Thu, 28 May 2015 01:08:33 -0400] rev 9660
Another attempt to get this to compile.

Thu, 28 May 2015 01:02:03 -0400Patched to compile on MingW.
Ryan C. Gordon <icculus@icculus.org> [Thu, 28 May 2015 01:02:03 -0400] rev 9659
Patched to compile on MingW.

(I think!)

Thu, 28 May 2015 00:54:52 -0400Move tests from SDL_config higher up in Windows joystick/haptic code.
Ryan C. Gordon <icculus@icculus.org> [Thu, 28 May 2015 00:54:52 -0400] rev 9658
Move tests from SDL_config higher up in Windows joystick/haptic code.

Fixes Bugzilla #2932.

Thu, 28 May 2015 00:30:21 -0400X11: Add Xdbe support to message boxes (thanks, Melker!).
Ryan C. Gordon <icculus@icculus.org> [Thu, 28 May 2015 00:30:21 -0400] rev 9657
X11: Add Xdbe support to message boxes (thanks, Melker!).

Without this, message boxes with a lot of text will noticibly flicker as
you mouse over buttons.

Fixes Bugzilla #2343.

Wed, 27 May 2015 19:00:56 -0400Patched to compile on C89 compilers.
Ryan C. Gordon <icculus@icculus.org> [Wed, 27 May 2015 19:00:56 -0400] rev 9656
Patched to compile on C89 compilers.