Mon, 07 Jul 2014 23:40:10 -0700Fixed code signing release frameworks
Sam Lantinga [Mon, 07 Jul 2014 23:40:10 -0700] rev 8995
Fixed code signing release frameworks

Mon, 07 Jul 2014 23:33:57 -0700Update audio testautomation: more coverage; added SDL_PauseAudio test /w callback coverage
Andreas Schiffler [Mon, 07 Jul 2014 23:33:57 -0700] rev 8994
Update audio testautomation: more coverage; added SDL_PauseAudio test /w callback coverage

Mon, 07 Jul 2014 23:26:34 -0700Fixed bug 2421 - SDL_RenderCopyEx off by one when rotating by 90 and -90
Sam Lantinga [Mon, 07 Jul 2014 23:26:34 -0700] rev 8993
Fixed bug 2421 - SDL_RenderCopyEx off by one when rotating by 90 and -90

chasesan

When using SDL_RenderCopyEx, I get a problem on some platforms where the output is offset by +/-1 on other platforms and not on others. I tried it with a center of both 0,0 (and offsetting by width/height) and NULL (for centered).

The rotation involved is 90, and/or -90 rotation. The rotation was a constant, no arithmetic was involved when inputting it into SDL_RenderCopyEx.

This occurred with 32x32, 24x24, and 16x16 texture sizes. I apologize that I don't have more precise information, as I received the information as a bug report myself. But I have tracked the problem down to here.

My program requires pixel perfect alignment on several different platforms, so this is something of a showstopper for me.

--

Sylvain

It appears the RenderCopyEx is done as expected,
this is the red rectangle which is not correctly positionned !

So, here's patch with a 0.5 float increment, like for opengles2, for DrawLines, and also Draw Points.

Mon, 07 Jul 2014 21:34:04 -0700Updated configure after removing pthread spinlock support
Sam Lantinga [Mon, 07 Jul 2014 21:34:04 -0700] rev 8992
Updated configure after removing pthread spinlock support

Mon, 07 Jul 2014 21:27:42 -0700Fixed bug 2618 - incomplete pthread-based lock support should be removed
Sam Lantinga [Mon, 07 Jul 2014 21:27:42 -0700] rev 8991
Fixed bug 2618 - incomplete pthread-based lock support should be removed

binarycrusader

Since changeset 358696c354a8, SDL 2.0 has been broken on Solaris when compiling with the Solaris Studio compiler (which uses the pthread implementation of SDL_AtomicLock).

Notably, it gets stuck at the MemoryBarrierRelease in SDL_GetErrBuf:

6585 # 218
6586 if (!tls_errbuf && !tls_being_created) {
6587 SDL_AtomicLock_REAL ( & tls_lock );
6588 if (!tls_errbuf) {
6589 SDL_TLSID slot;
6590 tls_being_created = SDL_TRUE;
6591 slot = SDL_TLSCreate_REAL ( );
6592 tls_being_created = SDL_FALSE;
6593 { SDL_SpinLock _tmp = 0 ; SDL_AtomicLock_REAL ( & _tmp ) ; SDL_AtomicUnlock_REAL ( & _tmp ) ; };
^^^ loops forever above
6594 tls_errbuf = slot;
6595 }
6596 SDL_AtomicUnlock_REAL ( & tls_lock );
6597 }


Running: testthread
(process id 28926)
^Cdbx: warning: Interrupt ignored but forwarded to child.
signal INT (Interrupt) in __nanosleep at 0xfe52a875
0xfe52a875: __nanosleep+0x0015: jae __nanosleep+0x23 [ 0xfe52a883, .+0xe ]
Current function is SDL_Delay_REAL
204 was_error = nanosleep(&tv, &elapsed);
(dbx) where
[1] __nanosleep(0xfeffe848, 0xfeffe850, 0xfe75a5ac, 0xfe5169d8), at 0xfe52a875
[2] nanosleep(0xfeffe848, 0xfeffe850), at 0xfe516a3b
=>[3] SDL_Delay_REAL(ms = 0), line 204 in "SDL_systimer.c"
[4] SDL_AtomicLock_REAL(lock = 0xfeffe88c), line 104 in "SDL_spinlock.c"
[5] SDL_GetErrBuf(), line 225 in "SDL_thread.c"
[6] SDL_ClearError_REAL(), line 216 in "SDL_error.c"
[7] SDL_InitSubSystem_REAL(flags = 0), line 116 in "SDL.c"
[8] SDL_Init_REAL(flags = 0), line 244 in "SDL.c"
[9] SDL_Init(a = 0), line 89 in "SDL_dynapi_procs.h"
[10] main(argc = 1, argv = 0xfeffe948), line 65 in "testthread.c"

As far as I can tell, this is because pthread_spin_trylock() always returns EBUSY for this particular lock; since it works in other places, I'm suspicious.

Different Solaris Studio compiler versions seem to make no difference.

I've verified this is broken on Linux as well if SDL_spinlock.c is modified to use the pthread implementation.

This appears to be because pthread_spin_init() and pthread_spin_destroy() are not used with the locks as required.

Mon, 07 Jul 2014 21:21:05 -0700Fixed bug 2628 - invalidate surface->map in SDL_SurfacePalette()
Sam Lantinga [Mon, 07 Jul 2014 21:21:05 -0700] rev 8990
Fixed bug 2628 - invalidate surface->map in SDL_SurfacePalette()

Wei Mingzhi

surface->map should be invalidated in SDL_SetSurfacePalette(), otherwise the palette would not be effective when blitting to another non-8bit surface which we previously blitted to.

Mon, 07 Jul 2014 20:26:21 -0700Enable 2 disabled audio tests (since bug 1396 is fixed and they pass now)
Andreas Schiffler [Mon, 07 Jul 2014 20:26:21 -0700] rev 8989
Enable 2 disabled audio tests (since bug 1396 is fixed and they pass now)

Mon, 07 Jul 2014 13:21:54 -0700Hopefully fixed Cygwin build
Sam Lantinga [Mon, 07 Jul 2014 13:21:54 -0700] rev 8988
Hopefully fixed Cygwin build

Mon, 07 Jul 2014 13:19:53 -0700Removed useless assert
Sam Lantinga [Mon, 07 Jul 2014 13:19:53 -0700] rev 8987
Removed useless assert

Mon, 07 Jul 2014 12:48:25 -0700Fixed bug 2631 - Mac: minor code cleanup
Sam Lantinga [Mon, 07 Jul 2014 12:48:25 -0700] rev 8986
Fixed bug 2631 - Mac: minor code cleanup

Alex Szpakowski

Some minor changes to the Mac-specific backend code:

- Fixed up some code style issues (mostly brace style inconsistencies).

- Fixed a compiler warning in SDL_cocoaevents.m.

- Removed some useless code now that the 10.7 SDK is required to build SDL.

- Removed Gestalt(gestaltSystemVersion, ...) call and switched to NSAppKitVersionNumber for version checking code. Using Gestalt with gestaltSystemVersion will give 0x1090 in Mac OS 10.10+, and the whole Gestalt function was deprecated in Mac OS 10.8.