Wed, 04 Sep 2019 09:27:58 -0700x11: add a hint to force the VisualID used when creating a window.
Sam Lantinga [Wed, 04 Sep 2019 09:27:58 -0700] rev 13057
x11: add a hint to force the VisualID used when creating a window.

Wed, 04 Sep 2019 00:39:47 -0400stdinc: On macOS and iOS, use memset_pattern4() for SDL_memset4().
Ryan C. Gordon [Wed, 04 Sep 2019 00:39:47 -0400] rev 13056
stdinc: On macOS and iOS, use memset_pattern4() for SDL_memset4().

Fixes Bugzilla #4724.

Tue, 03 Sep 2019 23:30:24 +0300riscos: send SDL_APPACTIVE events when iconizing the window SDL-1.2
Cameron Cawley [Tue, 03 Sep 2019 23:30:24 +0300] rev 13055
riscos: send SDL_APPACTIVE events when iconizing the window

Tue, 03 Sep 2019 23:11:10 +0300riscos: implement SDL_WM_IconifyWindow() SDL-1.2
Cameron Cawley [Tue, 03 Sep 2019 23:11:10 +0300] rev 13054
riscos: implement SDL_WM_IconifyWindow()

Tue, 03 Sep 2019 23:00:00 +0300SDL_bmp.c: reject bmp files with zero bpp SDL-1.2
Ozkan Sezer [Tue, 03 Sep 2019 23:00:00 +0300] rev 13053
SDL_bmp.c: reject bmp files with zero bpp

Fixes: https://bugzilla.libsdl.org/show_bug.cgi?id=4536
(2.0 commit: https://hg.libsdl.org/SDL/rev/6203d73874ab)

Tue, 03 Sep 2019 11:55:20 -0700Fixed bug 4536 - Heap-Buffer Overflow in SDL_GetRGB pertaining to SDL_pixels.c
Sam Lantinga [Tue, 03 Sep 2019 11:55:20 -0700] rev 13052
Fixed bug 4536 - Heap-Buffer Overflow in SDL_GetRGB pertaining to SDL_pixels.c

Ozkan Sezer

As for the issue: This bmp reports bpp=0, therefore SDL_CalculatePitch()
returns pitch==0, which is then fed to SDL_malloc() (which is malloc())
and malloc(0) returns _something_ which is not NULL but not someting
that we expect.. Then testsprite.c:LoadSprite() accesses the pixels
as *(Uint8*)pixels which valrind reports as:

==15533== Invalid read of size 1
==15533== at 0x8048C08: LoadSprite (testsprite.c:45)
==15533== by 0x80492FC: main (testsprite.c:224)
==15533== Address 0x449e588 is 0 bytes after a block of size 0 alloc'd
==15533== at 0x40072B2: malloc (vg_replace_malloc.c:270)
==15533== by 0x4045719: SDL_CreateRGBSurface (SDL_surface.c:126)
==15533== by 0x40403C1: SDL_LoadBMP_RW (SDL_bmp.c:237)
==15533== by 0x8048BB2: LoadSprite (testsprite.c:36)
==15533== by 0x80492FC: main (testsprite.c:224)

Besides, valrind also reports this:
==15533== Conditional jump or move depends on uninitialised value(s)
==15533== at 0x40403F3: SDL_LoadBMP_RW (SDL_bmp.c:247)
==15533== by 0x8048BB2: LoadSprite (testsprite.c:36)
==15533== by 0x80492FC: main (testsprite.c:224)


Easy/quick solution would be early-rejecting a bmp with 0 bpp from SDL_bmp.c:SDL_LoadBMP_RW()

Tue, 03 Sep 2019 16:49:46 +0100Fix spelling of RISC OS in the changelog SDL-1.2
Cameron Cawley [Tue, 03 Sep 2019 16:49:46 +0100] rev 13051
Fix spelling of RISC OS in the changelog

Mon, 02 Sep 2019 12:35:00 +0300SDL_bmp.c: restore most of the original formatting.
Ozkan Sezer [Mon, 02 Sep 2019 12:35:00 +0300] rev 13050
SDL_bmp.c: restore most of the original formatting.

Mon, 02 Sep 2019 00:11:58 -0400direct3d: Be more aggressive about resetting state when textures go away.
Ryan C. Gordon [Mon, 02 Sep 2019 00:11:58 -0400] rev 13049
direct3d: Be more aggressive about resetting state when textures go away.

Fixes Bugzilla #4768.

Sun, 01 Sep 2019 22:41:44 -0400d3d11: Fixed VB state, avoiding unnecessary recreation (Thanks, Alex!).
Ryan C. Gordon [Sun, 01 Sep 2019 22:41:44 -0400] rev 13048
d3d11: Fixed VB state, avoiding unnecessary recreation (Thanks, Alex!).

Fixes Bugzilla #4779.