Fri, 11 Dec 2009 08:03:43 +0000Fixed bug #896
Sam Lantinga <slouken@libsdl.org> [Fri, 11 Dec 2009 08:03:43 +0000] rev 3539
Fixed bug #896

John Popplewell 2009-12-08 23:05:50 PST

Originally reported by AKFoerster on the mailing list.

Error decoding UTF8 Russian text to UTF-16LE on Windows, but specifically on
platforms without iconv support (the default on Windows).

Valid UTF8 characters are flagged as being overlong and then substituted by the
UNKNOWN_UNICODE character.

After studying the testiconv.c example program, reading the RFCs and putting
some printf statements in SDL_iconv.c the problem is in a test for 'Maximum
overlong sequences', specifically 4.2.1, which is carried out by the following
code:

} else if ( p[0] >= 0xC0 ) {
if ( (p[0] & 0xE0) != 0xC0 ) {
/* Skip illegal sequences
return SDL_ICONV_EILSEQ;
*/
ch = UNKNOWN_UNICODE;
} else {
if ( (p[0] & 0xCE) == 0xC0 ) { <<<<<<<< here
overlong = SDL_TRUE;
}
ch = (Uint32)(p[0] & 0x1F);
left = 1;
}
} else {

Here is the 2-byte encoding of a character in range 00000080 - 000007FF
110xxxxx 10xxxxxx

The line in question is supposed to be checking for an overlong sequence which
would be less than
11000001 10111111

which should be represented as a single byte.

BUT, the mask value (0xCE) is wrong, it isn't checking the top-most bit:
11000001 value
11001110 mask (incorrect)
^
and should be (0xDE):
11000001 value
11011110 mask (correct)

making the above code:

} else if ( p[0] >= 0xC0 ) {
if ( (p[0] & 0xE0) != 0xC0 ) {
/* Skip illegal sequences
return SDL_ICONV_EILSEQ;
*/
ch = UNKNOWN_UNICODE;
} else {
if ( (p[0] & 0xDE) == 0xC0 ) { <<<<<<<< here
overlong = SDL_TRUE;
}
ch = (Uint32)(p[0] & 0x1F);
left = 1;
}
} else {

I can supply a test program and/or a patch if required,

best regards,
John Popplewell

Thu, 10 Dec 2009 09:27:23 +0000X11 driver compiles again, lines are not yet implemented
Sam Lantinga <slouken@libsdl.org> [Thu, 10 Dec 2009 09:27:23 +0000] rev 3538
X11 driver compiles again, lines are not yet implemented

Thu, 10 Dec 2009 08:28:26 +0000Switch to mixed case for consistency with other enumerations
Sam Lantinga <slouken@libsdl.org> [Thu, 10 Dec 2009 08:28:26 +0000] rev 3537
Switch to mixed case for consistency with other enumerations

Wed, 09 Dec 2009 15:56:56 +0000Added interfaces for batch drawing of points, lines and rects:
Sam Lantinga <slouken@libsdl.org> [Wed, 09 Dec 2009 15:56:56 +0000] rev 3536
Added interfaces for batch drawing of points, lines and rects:
SDL_DrawPoints()
SDL_BlendPoints()
SDL_BlendLines()
SDL_DrawLines()
SDL_FillRects()
SDL_BlendRects()
SDL_RenderPoints()
SDL_RenderLines()
SDL_RenderRects()
Renamed SDL_RenderFill() to SDL_RenderRect()

Mon, 07 Dec 2009 10:08:24 +0000Hey, those automated tests are coming in handy! Fixed GDI rendering semantics
Sam Lantinga <slouken@libsdl.org> [Mon, 07 Dec 2009 10:08:24 +0000] rev 3535
Hey, those automated tests are coming in handy! Fixed GDI rendering semantics

Mon, 07 Dec 2009 09:44:55 +0000Implemented RenderReadPixels() and RenderWritePixels() for GDI renderer.
Sam Lantinga <slouken@libsdl.org> [Mon, 07 Dec 2009 09:44:55 +0000] rev 3534
Implemented RenderReadPixels() and RenderWritePixels() for GDI renderer.

Mon, 07 Dec 2009 08:02:20 +0000This fixes the OpenGL rendering test, at least with my ATI card...
Sam Lantinga <slouken@libsdl.org> [Mon, 07 Dec 2009 08:02:20 +0000] rev 3533
This fixes the OpenGL rendering test, at least with my ATI card...

Mon, 07 Dec 2009 08:01:58 +0000Fixed crash initializing the dummy driver
Sam Lantinga <slouken@libsdl.org> [Mon, 07 Dec 2009 08:01:58 +0000] rev 3532
Fixed crash initializing the dummy driver

Mon, 07 Dec 2009 08:01:20 +0000On Windows the minimum window size may be larger than 80, so explicitly request the expected rectangle.
Sam Lantinga <slouken@libsdl.org> [Mon, 07 Dec 2009 08:01:20 +0000] rev 3531
On Windows the minimum window size may be larger than 80, so explicitly request the expected rectangle.

Sun, 06 Dec 2009 08:39:01 +0000The window position is display relative, at least for now...
Sam Lantinga <slouken@libsdl.org> [Sun, 06 Dec 2009 08:39:01 +0000] rev 3530
The window position is display relative, at least for now...