Tue, 14 Mar 2006 06:00:30 +0000Fixed bug #38
Sam Lantinga <slouken@libsdl.org> [Tue, 14 Mar 2006 06:00:30 +0000] rev 1525
Fixed bug #38

I'm using SDL 1.2.9 with Visual C++ 7.0 on Windows 2000.

Here's the setup: my game starts in a window, with
SDL_WM_GrabInput(SDL_GRAB_ON) to constrain the cursor to the game window. The
mouse cursor is outside of the window when the game launches, and when the
window appears the cursor is grabbed and placed at the top left corner of the
inside of the game window. At this point, if I click the mouse without moving
it, the SDL_MOUSEBUTTONDOWN event's mouse coordinates are (65535,65535).

Tue, 14 Mar 2006 05:34:39 +0000Fixed bug #46
Sam Lantinga <slouken@libsdl.org> [Tue, 14 Mar 2006 05:34:39 +0000] rev 1524
Fixed bug #46

Date: Fri, 13 Jan 2006 18:09:45 -0500
From: mhall4400 vipmail kvcc edu
Subject: Possible SDL bug

Greetings

I believe Ive come across a bug in your SDL product (1.2.9), in the CD-ROM
control portion of the library.

When calling the SDL_CDPlay() function to play the last track of a CD using the
offset and length from an SDL_CD structure generated by SDL_CDOpen(), I get the
following error from a call to SDL_Error():

mciSendCommand() error: The specified parameter is out of range for the
specified command.

The code returning the error is:
SDL_CDPlay(g_playingDriveSDLCD,
g_playingDriveSDLCD->track[trackNumberInt].offset,
g_playingDriveSDLCD->track[trackNumberInt].length)

Subtracting one from the length of the provided length seems to repair the
problem:
SDL_CDPlay(g_playingDriveSDLCD,
g_playingDriveSDLCD->track[trackNumberInt].offset,
(g_playingDriveSDLCD->track[trackNumberInt].length) - 1)

Ive replicated this problem on Windows 98 SE (several months since last
patch), fully-patched Window ME, seldom-patched Windows XP SP1, and
fully-patched Windows XP SP2.

While investigating the issue, I came across a line in your librarys win32
source code in file \src\cdrom\win32\SDL_syscdrom.c (source code zip archive
from your download page), function: SDL_SYS_CDGetTOC(), line 226 where you add
1 to the value for length to fix MCI last track length bug. This may be the
source of the issue (because subtracting 1 from the length seems to resolve the
issue). Microsoft may have patched the referenced bug since you wrote that
line.

Mike Hall

Tue, 14 Mar 2006 04:00:03 +0000(patch tweaked a bit)
Sam Lantinga <slouken@libsdl.org> [Tue, 14 Mar 2006 04:00:03 +0000] rev 1523
(patch tweaked a bit)

Date: Tue, 14 Mar 2006 03:30:11 +0000
From: Peter Mulholland
Subject: [SDL] Windows MessageBox() strangeness fixes

Hello all,

I *think* this should fix the issues that people were seeing with
MessageBox() not working and therefore assert() on mingw/msvc. Forgive
me if i've screwed up making the diff file - I'm a total newb when it
comes to things like CVS and diff.

It modifies a few files as I saw that FlushMessageQueue() was in both
the windx5 and windib driver, so I moved this into wincommon. It was
also in the gapi driver, so I changed that too. The function is now
WIN_FlushMessageQueue() in src/video/wincommon/SDL_syswm.c

Tue, 14 Mar 2006 03:04:50 +0000*** empty log message ***
Sam Lantinga <slouken@libsdl.org> [Tue, 14 Mar 2006 03:04:50 +0000] rev 1522
*** empty log message ***

Tue, 14 Mar 2006 02:46:26 +0000CFLAGS are separate from EXTRA_CFLAGS
Sam Lantinga <slouken@libsdl.org> [Tue, 14 Mar 2006 02:46:26 +0000] rev 1521
CFLAGS are separate from EXTRA_CFLAGS
Fixed iconv.h detection on Cygwin32

Mon, 13 Mar 2006 18:01:34 +0000Add the NAS library directory, since X11 is dynamically loaded now...
Sam Lantinga <slouken@libsdl.org> [Mon, 13 Mar 2006 18:01:34 +0000] rev 1520
Add the NAS library directory, since X11 is dynamically loaded now...
FIXME: See if we can dynamically load NAS

Mon, 13 Mar 2006 17:25:44 +0000RFC 3629 restricted the range of characters encoded with UTF-8 to 0000-10FFFF (the UTF-16 accessible range)
Sam Lantinga <slouken@libsdl.org> [Mon, 13 Mar 2006 17:25:44 +0000] rev 1519
RFC 3629 restricted the range of characters encoded with UTF-8 to 0000-10FFFF (the UTF-16 accessible range)

Mon, 13 Mar 2006 16:56:01 +0000Updated by Ryan Gordon
Sam Lantinga <slouken@libsdl.org> [Mon, 13 Mar 2006 16:56:01 +0000] rev 1518
Updated by Ryan Gordon

Mon, 13 Mar 2006 05:44:14 +0000*** empty log message ***
Sam Lantinga <slouken@libsdl.org> [Mon, 13 Mar 2006 05:44:14 +0000] rev 1517
*** empty log message ***

Mon, 13 Mar 2006 05:36:42 +0000Updated MacOS Classic build
Sam Lantinga <slouken@libsdl.org> [Mon, 13 Mar 2006 05:36:42 +0000] rev 1516
Updated MacOS Classic build