Mon, 01 May 2006 06:40:00 +0000SDL_sysjoystick.c:983: warning: 'return' with a value, in function returning void
Sam Lantinga <slouken@libsdl.org> [Mon, 01 May 2006 06:40:00 +0000] rev 1752
SDL_sysjoystick.c:983: warning: 'return' with a value, in function returning void

Sun, 30 Apr 2006 21:01:25 +0000Declare volatile variables modified by interrupt routines
Patrice Mandin <patmandin@gmail.com> [Sun, 30 Apr 2006 21:01:25 +0000] rev 1751
Declare volatile variables modified by interrupt routines

Sun, 30 Apr 2006 16:53:40 +0000Removed redundant rm
Sam Lantinga <slouken@libsdl.org> [Sun, 30 Apr 2006 16:53:40 +0000] rev 1750
Removed redundant rm

Sun, 30 Apr 2006 08:57:02 +0000We want to wrap HAVE_ALLOCA_H, not HAVE_ALLOCA. :)
Sam Lantinga <slouken@libsdl.org> [Sun, 30 Apr 2006 08:57:02 +0000] rev 1749
We want to wrap HAVE_ALLOCA_H, not HAVE_ALLOCA. :)

Sat, 29 Apr 2006 20:22:31 +0000------- Comment #1 From Max Horn 2006-04-17 03:08 [reply] -------
Sam Lantinga <slouken@libsdl.org> [Sat, 29 Apr 2006 20:22:31 +0000] rev 1748
------- Comment #1 From Max Horn 2006-04-17 03:08 [reply] -------

Created an attachment (id=106) [edit]
Patch for src/joystick/win32/SDL_mmjoystick.c

I am not even a Windows user, so take the following with a grain of salt:

SDL_mmjoystick.c has a function GetJoystickName which obtains the joystick
name by looking at the registry. The way it does that seems very fishy to me.
Namely, it uses the parameter "index" to construct a registry value name (BTW,
those variables used in the code are really badly named). The value of "index"
in turn equals the current value of "numdevs", as called from
SDL_SYS_JoystickInit.

I read through the MSDN docs at
<http://msdn.microsoft.com/archive/default.asp?url=/archive/en-us/dnarinput/html/msdn_extdirect.asp>,
and I believe the simple fix is to replace line 183 of said file
SYS_JoystickName[numdevs] = GetJoystickName(numdevs, joycaps.szRegKey);
by the following:
SYS_JoystickName[numdevs] = GetJoystickName(SYS_JoystickID[i],
joycaps.szRegKey);

However, that is only *hiding* the real issue. Problem is, the list of
joysticks as returned by windows may contains "gaps", and the code deals
incorrectly with that. Namely those gaps occur if joysticks are
removed/(re)added, as the reporter observed.

The attached patch fixes this and another (off-by-one) issue in the code. But
since I have no Windows machine, I can't even test-compile it, so use with
caution.

Sat, 29 Apr 2006 17:56:06 +0000(none)
Sam Lantinga <slouken@libsdl.org> [Sat, 29 Apr 2006 17:56:06 +0000] rev 1747
(none)

Sat, 29 Apr 2006 17:54:32 +0000Disable the XRandR extension by default, since KDE maximizes windows which are larger than the new resolution, and then doesn't restore their size and positition when the old resolution is restored.
Sam Lantinga <slouken@libsdl.org> [Sat, 29 Apr 2006 17:54:32 +0000] rev 1746
Disable the XRandR extension by default, since KDE maximizes windows which are larger than the new resolution, and then doesn't restore their size and positition when the old resolution is restored.
The extension can be enabled with the environment variable SDL_VIDEO_X11_XRANDR=1

Sat, 29 Apr 2006 04:08:40 +0000Only use -fvisibility=hidden if SDL will define some symbols as available. :)
Sam Lantinga <slouken@libsdl.org> [Sat, 29 Apr 2006 04:08:40 +0000] rev 1745
Only use -fvisibility=hidden if SDL will define some symbols as available. :)

Fri, 28 Apr 2006 05:46:07 +0000[From Sam]
Sam Lantinga <slouken@libsdl.org> [Fri, 28 Apr 2006 05:46:07 +0000] rev 1744
[From Sam]
> BTW, when setting up parallel make, I usually use # cpus + 1, so a compile is
> running while disk access is going for another.

[From Ryan]
My experience is that this works well on Linux, but is actually slower on
PowerPC Mac OS X...not sure if that's an architecture issue or a scheduler
issue, though, and haven't tried it on Intel Mac OS X.

Fri, 28 Apr 2006 05:43:58 +0000Future proof C++ code
Sam Lantinga <slouken@libsdl.org> [Fri, 28 Apr 2006 05:43:58 +0000] rev 1743
Future proof C++ code