Thu, 10 Aug 2017 11:57:19 -0700Fixed bug 3681 - SDL_UpateTexture documentation not specific enough about format requirement
Sam Lantinga <slouken@libsdl.org> [Thu, 10 Aug 2017 11:57:19 -0700] rev 11216
Fixed bug 3681 - SDL_UpateTexture documentation not specific enough about format requirement

Simon Hug

The documentation of SDL_UpateTexture does not say that the pixel data has to be in the format of the texture.

Wed, 09 Aug 2017 20:26:16 -0700Fixed bug 3701 - WM_TOUCH message may cause calls to null if touch functions are not properly loaded
Sam Lantinga <slouken@libsdl.org> [Wed, 09 Aug 2017 20:26:16 -0700] rev 11215
Fixed bug 3701 - WM_TOUCH message may cause calls to null if touch functions are not properly loaded

Simon Hug

When WIN_WindowProc processes the WM_TOUCH message, it doesn't check if the touch functions have been properly loaded and may call a NULL pointer. It's probably an extremely rare case, but here's a patch that adds some checks anyway.

Wed, 09 Aug 2017 20:23:48 -0700Fixed bug 3728 - [Android] crash when shared libraries are no loaded
Sam Lantinga <slouken@libsdl.org> [Wed, 09 Aug 2017 20:23:48 -0700] rev 11214
Fixed bug 3728 - [Android] crash when shared libraries are no loaded

Sylvain

On Android, when shared libraries are not correctly loaded (eg SDLActivity.mBrokenLibraries is true), there is a pop-up with an error message.

After user dismisses the pop-up, application crashes:
- because the native function "nativePause()" may no be loaded (if libSDL2.so is not loaded).
- because mSurface is null.

Wed, 09 Aug 2017 20:20:35 -0700Fixed bug 3672 - Add joystick to controllerdb
Sam Lantinga <slouken@libsdl.org> [Wed, 09 Aug 2017 20:20:35 -0700] rev 11213
Fixed bug 3672 - Add joystick to controllerdb

Moritz M-H

The following entry needs to be added to the gamecontrollerdb for the Qanba fighter stick under linux

Wed, 09 Aug 2017 22:43:16 -0400cmake: Pacify warning about Policy CMP0042 not being set.
Ryan C. Gordon <icculus@icculus.org> [Wed, 09 Aug 2017 22:43:16 -0400] rev 11212
cmake: Pacify warning about Policy CMP0042 not being set.

Wed, 09 Aug 2017 22:34:45 -0400cmake: whoops, Sam and I both fixed this bug at the same time. :)
Ryan C. Gordon <icculus@icculus.org> [Wed, 09 Aug 2017 22:34:45 -0400] rev 11211
cmake: whoops, Sam and I both fixed this bug at the same time. :)

Wed, 09 Aug 2017 19:03:10 -0700Fixed bug 3651 - CMake build does not install CMake package configuration
Sam Lantinga <slouken@libsdl.org> [Wed, 09 Aug 2017 19:03:10 -0700] rev 11210
Fixed bug 3651 - CMake build does not install CMake package configuration

tschwinger@elitemail.org

Most ironically, although autoconf/automake-based builds install (pretty half-assed) CMake package configuration files, they're missing in installations resulting from CMake-based builds entirely.

A proper configuration file typically also loads target exports (implemented in patch 3572, also fixing this issue - see my comment on that issue for details).

I believe it would be best to let the dinosaurs go extinct and redirect all build efforts to the CMake end for two reasons:

1. It potentially provides the best user experience, but you'd have to give it some love and ship with less quirky buildfiles.

2. It would force distros to build SDL via CMake and thus would ensure target exports are actually available everywhere.

Various CMake patches I submitted today in summary (directly converted from the HG commits and `am`d onto a fork of a git mirror that happened to be on `tip`).

https://github.com/tschw/SDL/commits/patched

Fixing #2576 #3572, #3613, and this fresh ticket, which is almost entirely advertisement ;).

These already do to make SDL much less of a quirky fella to have in your dependency tree...

Wed, 09 Aug 2017 18:47:33 -0700Fixed bug 3590 - CMAKE: typos in CheckMir
Sam Lantinga <slouken@libsdl.org> [Wed, 09 Aug 2017 18:47:33 -0700] rev 11209
Fixed bug 3590 - CMAKE: typos in CheckMir

Martin Gerhardy

- list(APPEND EXTRA_CFLAGS ${MIR_TOOLKIT_CFLAGS} ${EGL_CLFAGS} ${XKB_CLFLAGS})
+ list(APPEND EXTRA_CFLAGS ${MIR_TOOLKIT_CFLAGS} ${EGL_CFLAGS} ${XKB_CFLAGS})

CFLAGS is spelled wrong in two different ways for EGL and XKB

And while you are on it...

sdl needs mir >= 0.24 afaik - it fails on travis-ci (ubuntu 14.04 LTS with 0.18 installed and in other environments, too (e.g. https://github.com/urho3d/Urho3D/issues/1685)

To fix this one should add a min version check to pkg_check_modules like this

- pkg_check_modules(MIR_TOOLKIT mirclient mircommon)
+ pkg_check_modules(MIR_TOOLKIT mirclient>=0.24 mircommon)

Wed, 09 Aug 2017 19:50:18 -0400cmake: Don't link directly against a libpthread on Android (thanks, Anthony!).
Ryan C. Gordon <icculus@icculus.org> [Wed, 09 Aug 2017 19:50:18 -0400] rev 11208
cmake: Don't link directly against a libpthread on Android (thanks, Anthony!).

Android has pthreads, but it's just part of their C runtime instead of a
separate library like the usual Linux platforms.

Fixes Bugzilla #3675.

Thu, 08 Jun 2017 22:07:55 +0300Android build fixes
Olli Kallioinen <olli.kallioinen@iki.fi> [Thu, 08 Jun 2017 22:07:55 +0300] rev 11207
Android build fixes
-Enabling checking for GCC_ATOMICS also on clang by default. This way all Android ABIs build successfully
-Android cmake: Threading was not enabled correctly
-Android cmake: Timers and dynamic lib loading were not included in the sources