Wed, 29 Oct 2014 20:29:32 +0100Fixed SDL_AddHintCallback() crashing if no more memory available.
Philipp Wiesemann [Wed, 29 Oct 2014 20:29:32 +0100] rev 9202
Fixed SDL_AddHintCallback() crashing if no more memory available.

The return value of SDL_malloc() was not checked and NULL therefore not handled.
Also added setting of error message for the other SDL_malloc() in this function.

Wed, 29 Oct 2014 20:20:47 +0100Fixed bug 2647 - Memory leak in SDL_AddHintCallback function - SDL_hints.c
Philipp Wiesemann [Wed, 29 Oct 2014 20:20:47 +0100] rev 9201
Fixed bug 2647 - Memory leak in SDL_AddHintCallback function - SDL_hints.c

Nitz

Variable entry going out of scope leaks the storage it points to, at:

/* Need to add a hint entry for this watcher */
hint = (SDL_Hint *)SDL_malloc(sizeof(*hint));
if (!hint) {
return;
}

Patch is attached.

Mon, 27 Oct 2014 19:53:44 -0400WinRT: detailed steps, via the WinRT README, to fix a common build error
David Ludwig [Mon, 27 Oct 2014 19:53:44 -0400] rev 9200
WinRT: detailed steps, via the WinRT README, to fix a common build error

Mon, 27 Oct 2014 12:53:47 +0100Fixed two typos in header file comment.
Philipp Wiesemann [Mon, 27 Oct 2014 12:53:47 +0100] rev 9199
Fixed two typos in header file comment.

Sun, 26 Oct 2014 23:28:45 +0100Added handling of NULL as input for SDL_GameControllerAddMapping().
Philipp Wiesemann [Sun, 26 Oct 2014 23:28:45 +0100] rev 9198
Added handling of NULL as input for SDL_GameControllerAddMapping().

Sun, 26 Oct 2014 23:22:53 +0100Fixed SDL_GameControllerMappingForGUID() crashing if no more memory available.
Philipp Wiesemann [Sun, 26 Oct 2014 23:22:53 +0100] rev 9197
Fixed SDL_GameControllerMappingForGUID() crashing if no more memory available.

The return value of SDL_malloc() was not checked and NULL therefore not handled.
NULL returned by SDL_GameControllerMapping()/SDL_GameControllerMappingForGUID()
now either means "no mapping" (as before) or "no memory" (just crashed before).

Sun, 26 Oct 2014 17:53:16 +0100Added handling of NULL as input for SDL_GameControllerMapping().
Philipp Wiesemann [Sun, 26 Oct 2014 17:53:16 +0100] rev 9196
Added handling of NULL as input for SDL_GameControllerMapping().

For consistency with the similar functions getting SDL_GameController as input.
Also NULL is no SDL_GameController and therefore can not have a mapping anyway.

Sun, 26 Oct 2014 17:46:11 +0100Removed two wrong documentation comments from gamecontroller source.
Philipp Wiesemann [Sun, 26 Oct 2014 17:46:11 +0100] rev 9195
Removed two wrong documentation comments from gamecontroller source.

No replacement because correct documentation is already in SDL_gamecontroller.h.

Sun, 26 Oct 2014 17:44:00 +0100Fixed wording in SDL_GameControllerAddMappingsFromRW() error message.
Philipp Wiesemann [Sun, 26 Oct 2014 17:44:00 +0100] rev 9194
Fixed wording in SDL_GameControllerAddMappingsFromRW() error message.

Sun, 26 Oct 2014 12:33:10 -0400WinRT: more keyboard code cleanups
David Ludwig [Sun, 26 Oct 2014 12:33:10 -0400] rev 9193
WinRT: more keyboard code cleanups
- made keycode listings a bit easier to read
- listed VK_ keycode names, where appropriate
- removed a few pieces of dead + commented-out code
- applied a common 'WINRT_' prefix to internal function names