include/SDL_config_wiz.h
author Sam Lantinga <slouken@libsdl.org>
Sat, 09 Sep 2017 08:36:37 -0700
changeset 11480 e7a79b236dc0
parent 10903 875e0bb9646c
child 11610 6dea196ecbcb
permissions -rw-r--r--
Fixed bug 3760 - RWops doesn't check for integer overflow when stdio_fseek only supports 32 bits

Simon Hug

When RWops seeks with fseek or fseeko it uses the types long or off_t which can be 32 bits on some platforms. stdio_seek does not check if the 64-bit integer for the offset fits into a 32-bit integer. Offsets equal or larger than 2 GiB will have implementation-defined behavior and failure states would be very confusing to debug.

The attached patch adds range checking by using the macros from limits.h for long type and some bit shifting for off_t because POSIX couldn't be bothered to specify min and max macros.

It also defines HAVE_FSEEKI64 in SDL_config_windows.h so that the Windows function gets picked up automatically with the default config.

And there's an additional error message for when ftell fails.
     1 /*
     2   Simple DirectMedia Layer
     3   Copyright (C) 1997-2017 Sam Lantinga <slouken@libsdl.org>
     4 
     5   This software is provided 'as-is', without any express or implied
     6   warranty.  In no event will the authors be held liable for any damages
     7   arising from the use of this software.
     8 
     9   Permission is granted to anyone to use this software for any purpose,
    10   including commercial applications, and to alter it and redistribute it
    11   freely, subject to the following restrictions:
    12 
    13   1. The origin of this software must not be misrepresented; you must not
    14      claim that you wrote the original software. If you use this software
    15      in a product, an acknowledgment in the product documentation would be
    16      appreciated but is not required.
    17   2. Altered source versions must be plainly marked as such, and must not be
    18      misrepresented as being the original software.
    19   3. This notice may not be removed or altered from any source distribution.
    20 */
    21 
    22 #ifndef SDL_config_wiz_h_
    23 #define SDL_config_wiz_h_
    24 #define SDL_config_h_
    25 
    26 /* This is a set of defines to configure the SDL features */
    27 
    28 /* General platform specific identifiers */
    29 #include "SDL_platform.h"
    30 
    31 #define SDL_BYTEORDER 1234
    32 
    33 #define STDC_HEADERS 1
    34 #define HAVE_ALLOCA_H 1
    35 #define HAVE_CTYPE_H 1
    36 #define HAVE_ICONV_H 1
    37 #define HAVE_INTTYPES_H 1
    38 #define HAVE_LIMITS_H 1
    39 #define HAVE_MALLOC_H 1
    40 #define HAVE_MATH_H 1
    41 #define HAVE_MEMORY_H 1
    42 #define HAVE_SIGNAL_H 1
    43 #define HAVE_STDARG_H 1
    44 #define HAVE_STDINT_H 1
    45 #define HAVE_STDIO_H 1
    46 #define HAVE_STDLIB_H 1
    47 #define HAVE_STRINGS_H 1
    48 #define HAVE_STRING_H 1
    49 #define HAVE_SYS_TYPES_H 1
    50 
    51 #define HAVE_MALLOC 1
    52 #define HAVE_CALLOC 1
    53 #define HAVE_REALLOC 1
    54 #define HAVE_FREE 1
    55 #define HAVE_ALLOCA 1
    56 #define HAVE_GETENV 1
    57 #define HAVE_SETENV 1
    58 #define HAVE_PUTENV 1
    59 #define HAVE_UNSETENV 1
    60 #define HAVE_QSORT 1
    61 #define HAVE_ABS 1
    62 #define HAVE_BCOPY 1
    63 #define HAVE_MEMSET 1
    64 #define HAVE_MEMCPY 1
    65 #define HAVE_MEMMOVE 1
    66 #define HAVE_STRLEN 1
    67 #define HAVE_STRDUP 1
    68 #define HAVE_STRCHR 1
    69 #define HAVE_STRRCHR 1
    70 #define HAVE_STRSTR 1
    71 #define HAVE_STRTOL 1
    72 #define HAVE_STRTOUL 1
    73 #define HAVE_STRTOLL 1
    74 #define HAVE_STRTOULL 1
    75 #define HAVE_ATOI 1
    76 #define HAVE_ATOF 1
    77 #define HAVE_STRCMP 1
    78 #define HAVE_STRNCMP 1
    79 #define HAVE_STRCASECMP 1
    80 #define HAVE_STRNCASECMP 1
    81 #define HAVE_VSSCANF 1
    82 #define HAVE_VSNPRINTF 1
    83 #define HAVE_M_PI 1
    84 #define HAVE_CEIL 1
    85 #define HAVE_COPYSIGN 1
    86 #define HAVE_COS 1
    87 #define HAVE_COSF 1
    88 #define HAVE_FABS 1
    89 #define HAVE_FLOOR 1
    90 #define HAVE_LOG 1
    91 #define HAVE_SCALBN 1
    92 #define HAVE_SIN 1
    93 #define HAVE_SINF 1
    94 #define HAVE_SQRT 1
    95 #define HAVE_SQRTF 1
    96 #define HAVE_TAN 1
    97 #define HAVE_TANF 1
    98 #define HAVE_SIGACTION 1
    99 #define HAVE_SETJMP 1
   100 #define HAVE_NANOSLEEP 1
   101 #define HAVE_POW 1
   102 
   103 #define SDL_AUDIO_DRIVER_DUMMY 1
   104 #define SDL_AUDIO_DRIVER_OSS 1
   105 
   106 #define SDL_INPUT_LINUXEV 1
   107 #define SDL_INPUT_TSLIB 1
   108 #define SDL_JOYSTICK_LINUX 1
   109 #define SDL_HAPTIC_LINUX 1
   110 
   111 #define SDL_LOADSO_DLOPEN 1
   112 
   113 #define SDL_THREAD_PTHREAD 1
   114 #define SDL_THREAD_PTHREAD_RECURSIVE_MUTEX_NP 1
   115 
   116 #define SDL_TIMER_UNIX 1
   117 
   118 #define SDL_VIDEO_DRIVER_DUMMY 1
   119 #define SDL_VIDEO_DRIVER_PANDORA 1
   120 #define SDL_VIDEO_RENDER_OGL_ES 1
   121 #define SDL_VIDEO_OPENGL_ES 1
   122 
   123 #endif /* SDL_config_wiz_h_ */