author Sam Lantinga <>
Tue, 12 Dec 2017 16:34:16 -0800
changeset 11771 cb68160b3ace
parent 10737 3406a0f8b041
child 11811 5d94cb6b24d3
permissions -rw-r--r--
Fixed bug 3981 - Inverted logic bug in SDL_renderer "overscan" feature

Eric wing

There is a tiny bug in the new overscan code for the SDL_renderer.

In SDL_renderer.c, line 1265, the if check for SDL_strcasecmp with "direct3d" needs to be inverted.

Instead of:
if(SDL_strcasecmp("direct3d", SDL_GetCurrentVideoDriver())) {

It should be:
if(0 == SDL_strcasecmp("direct3d", SDL_GetCurrentVideoDriver())) {

This bug causes the "overscan" mode to pretty much be completely ignored in all cases and all things remain letterboxed (as before the feature).
     2 Simple DirectMedia Layer
     3 Copyright (C) 1997-2017 Sam Lantinga <>
     5 This software is provided 'as-is', without any express or implied
     6 warranty.  In no event will the authors be held liable for any damages
     7 arising from the use of this software.
     9 Permission is granted to anyone to use this software for any purpose,
    10 including commercial applications, and to alter it and redistribute it
    11 freely, subject to the following restrictions:
    13 1. The origin of this software must not be misrepresented; you must not
    14    claim that you wrote the original software. If you use this software
    15    in a product, an acknowledgment in the product documentation would be
    16    appreciated but is not required. 
    17 2. Altered source versions must be plainly marked as such, and must not be
    18    misrepresented as being the original software.
    19 3. This notice may not be removed or altered from any source distribution.