CREDITS.txt
author Sam Lantinga <slouken@libsdl.org>
Fri, 28 Nov 2014 04:51:33 -0800
changeset 9246 a761913e5e91
parent 7635 c57071e3d636
permissions -rw-r--r--
Fixed bug 2786 - "UCS-2-INTERNAL" iconv encoding is not supported everywhere, use UTF-16LE instead

Jonas Kulla

src/main/windows/SDL_windows_main.c:137:
cmdline = SDL_iconv_string("UTF-8", "UCS-2-INTERNAL", (char *)(text), (SDL_wcslen(text)+1)*sizeof(WCHAR));

I'm trying to compile an SDL2 application for windows using the mingw-w64 32bit toolchain provided by my distro (Fedora 19). However, even the simplest test program that does nothing at all fails to startup with a "Fatal error - out of memory" message because the mingw iconv library provided by my distro does not support the "UCS-2-INTERNAL" encoding and the conversion returns null.

From my little bit of research, it turns out that even though this encoding is supported by the external GNU libiconv library, some glibc versions (?) don't support it with their internal iconv routines, and will instead provide the native endian encoding when "UCS-2" is specified.

Nonetheless, I wonder why the native endianness is considered in the first place when Windows doesn't even run on any big endian archs (to my knowledge). And true enough, 'WIN_StringToUTF8' from core/windows/SDL_windows.h is used everywhere else in the windows backend, which is just a macro to iconv with "UTF-16LE" as source. Therefore it would IMO make sense to use this macro here as well, which would solve my problem (patch attached).
     1 
     2 Simple DirectMedia Layer CREDITS
     3 Thanks to everyone who made this possible, including:
     4 
     5 * Cliff Matthews, for giving me a reason to start this project. :)
     6  -- Executor rocks!  *grin*
     7 
     8 * Ryan Gordon for helping everybody out and keeping the dream alive. :)
     9 
    10 * Gabriel Jacobo for his work on the Android port and generally helping out all around.
    11  
    12 * Philipp Wiesemann for his attention to detail reviewing the entire SDL code base and proposes patches.
    13 
    14 * Andreas Schiffler for his dedication to unit tests, Visual Studio projects, and managing the Google Summer of Code.
    15 
    16 * Mike Sartain for incorporating SDL into Team Fortress 2 and cheering me on at Valve.
    17 
    18 * Alfred Reynolds for the game controller API and general (in)sanity
    19 
    20 * Jørgen Tjernø for numerous magical Mac OS X fixes.
    21 
    22 * Pierre-Loup Griffais for his deep knowledge of OpenGL drivers.
    23  
    24 * Julian Winter for the SDL 2.0 website.
    25 
    26 * Sheena Smith for many months of great work on the SDL wiki creating the API documentation and style guides.
    27 
    28 * Paul Hunkin for his port of SDL to Android during the Google Summer of Code 2010.
    29 
    30 * Eli Gottlieb for his work on shaped windows during the Google Summer of Code 2010.
    31 
    32 * Jim Grandpre for his work on multi-touch and gesture recognition during
    33   the Google Summer of Code 2010.
    34 
    35 * Edgar "bobbens" Simo for his force feedback API development during the
    36   Google Summer of Code 2008.
    37 
    38 * Aaron Wishnick for his work on audio resampling and pitch shifting during
    39   the Google Summer of Code 2008.
    40 
    41 * Holmes Futrell for his port of SDL to the iPhone and iPod Touch during the
    42   Google Summer of Code 2008.
    43 
    44 * Jon Atkins for SDL_image, SDL_mixer and SDL_net documentation.
    45 
    46 * Everybody at Loki Software, Inc. for their great contributions!
    47 
    48  And a big hand to everyone else who has contributed over the years.
    49 
    50 THANKS! :)
    51 
    52   -- Sam Lantinga			<slouken@libsdl.org>
    53