author Ryan C. Gordon
Mon, 21 Aug 2017 00:42:06 -0400
changeset 11334 749cb40916f2
parent 8722 9203a56e7ffc
child 12391 ca6e41ade79a
permissions -rwxr-xr-x
x11: specify event mask for buttons when grabbing pointer (thanks, Stas!).

This fixes a strange corner case (notes appended below), and should be
safe to do anyhow.

Fixes Bugzilla #3674.

"I did more tests.
It appears the bug only happens if there is
another window on the screen that has "always
on top" property. For me it is xawtv - it is
always opened in a screen corner. Closing
xawtv or removing "always on top" property
from it makes the problem to go away.
Plus, it doesn't appear like the buttons are
not delivered at all. It appears that instead
the button presses are delivered on some mouse
positions, but not delivered when you move the
mouse to other part of the window... So this is
really weird and is likely somewhere deep in the
Maybe somehow it happens that the cursor is
actually above the xawtv window, but, because
my app uses grab, it is not visible there, and
in that case the events are not delivered to
my app?
But with my patch the button events are
always delivered flawlessly, it seems.

Hmm, and that indeed seems to explain my problem:
if the mask is set properly and my app uses
grab, then, even if the mouse is above some
other window, the events would still be delivered
to the grabbing app, which is what actually wanted
because my app uses relative mouse mode, so it
doesn't know the pointer can cross some other window
(my app draws the pointer itself).
So my current theory is that my patch only enforces
the mouse grab, which otherwise can be tricked by
some other window preventing the button events
delivery (but motion events are still delivered
via xinput2, which makes it all look very obscure)."
     1 #!/bin/bash
     3 # This is the script uses to cross-compile SDL2 from
     4 #  x86 Linux to Raspberry Pi.
     6 # The final tarball can be unpacked in the root directory of a RPi,
     7 #  so the SDL2 install lands in /usr/local. Run ldconfig, and then
     8 #  you should be able to build and run SDL2-based software on your
     9 #  Pi. Standard configure scripts should be able to find SDL and
    10 #  build against it, and sdl2-config should work correctly on the
    11 #  actual device.
    13 TARBALL="$1"
    14 if [ -z $1 ]; then
    15     TARBALL=sdl-raspberrypi.tar.xz
    16 fi
    18 OSTYPE=`uname -s`
    19 if [ "$OSTYPE" != "Linux" ]; then
    20     # !!! FIXME
    21     echo "This only works on x86 or x64-64 Linux at the moment." 1>&2
    22     exit 1
    23 fi
    25 if [ "x$MAKE" == "x" ]; then
    26     NCPU=`cat /proc/cpuinfo |grep vendor_id |wc -l`
    27     let NCPU=$NCPU+1
    28     MAKE="make -j$NCPU"
    29 fi
    31 BUILDBOTDIR="raspberrypi-buildbot"
    34 set -e
    35 set -x
    36 rm -f $TARBALL
    37 rm -rf $BUILDBOTDIR
    38 mkdir -p $BUILDBOTDIR
    39 pushd $BUILDBOTDIR
    41 SYSROOT="/opt/rpi-sysroot"
    42 export CC="ccache /opt/rpi-tools/arm-bcm2708/gcc-linaro-arm-linux-gnueabihf-raspbian/bin/arm-linux-gnueabihf-gcc --sysroot=$SYSROOT -I$SYSROOT/opt/vc/include -I$SYSROOT/usr/include -I$SYSROOT/opt/vc/include/interface/vcos/pthreads -I$SYSROOT/opt/vc/include/interface/vmcs_host/linux -L$SYSROOT/opt/vc/lib"
    43 # -L$SYSROOT/usr/lib/arm-linux-gnueabihf"
    44 # !!! FIXME: shouldn't have to --disable-* things here.
    45 ../configure --with-sysroot=$SYSROOT --host=arm-raspberry-linux-gnueabihf --prefix=$PWD/rpi-sdl2-installed --disable-pulseaudio --disable-esd --disable-video-mir --disable-video-wayland
    46 $MAKE
    47 $MAKE install
    48 # Fix up a few things to a real install path on a real Raspberry Pi...
    49 perl -w -pi -e "s#$PWD/rpi-sdl2-installed#/usr/local#g;" ./rpi-sdl2-installed/lib/ ./rpi-sdl2-installed/lib/pkgconfig/sdl2.pc ./rpi-sdl2-installed/bin/sdl2-config
    50 mkdir -p ./usr
    51 mv ./rpi-sdl2-installed ./usr/local
    53 popd
    54 tar -cJvvf $TARBALL -C $BUILDBOTDIR usr
    55 rm -rf $BUILDBOTDIR
    57 set +x
    58 echo "All done. Final installable is in $TARBALL ...";