author Ryan C. Gordon
Mon, 21 Aug 2017 00:42:06 -0400
changeset 11334 749cb40916f2
parent 10593 9cfaba7f1d66
permissions -rwxr-xr-x
x11: specify event mask for buttons when grabbing pointer (thanks, Stas!).

This fixes a strange corner case (notes appended below), and should be
safe to do anyhow.

Fixes Bugzilla #3674.

"I did more tests.
It appears the bug only happens if there is
another window on the screen that has "always
on top" property. For me it is xawtv - it is
always opened in a screen corner. Closing
xawtv or removing "always on top" property
from it makes the problem to go away.
Plus, it doesn't appear like the buttons are
not delivered at all. It appears that instead
the button presses are delivered on some mouse
positions, but not delivered when you move the
mouse to other part of the window... So this is
really weird and is likely somewhere deep in the
Maybe somehow it happens that the cursor is
actually above the xawtv window, but, because
my app uses grab, it is not visible there, and
in that case the events are not delivered to
my app?
But with my patch the button events are
always delivered flawlessly, it seems.

Hmm, and that indeed seems to explain my problem:
if the mask is set properly and my app uses
grab, then, even if the mouse is above some
other window, the events would still be delivered
to the grabbing app, which is what actually wanted
because my app uses relative mouse mode, so it
doesn't know the pointer can cross some other window
(my app draws the pointer itself).
So my current theory is that my patch only enforces
the mouse grab, which otherwise can be tricked by
some other window preventing the button events
delivery (but motion events are still delivered
via xinput2, which makes it all look very obscure)."
     1 #!/bin/bash
     3 # This is the script uses to cross-compile SDL2 from
     4 #  amd64 Linux to NaCl.
     6 # PLEASE NOTE that we have reports that SDL built with pepper_49 (current
     7 #  stable release as of November 10th, 2016) is broken. Please retest
     8 #  when something newer becomes stable and then decide if this was SDL's
     9 #  bug or NaCl's bug.  --ryan.
    10 export NACL_SDK_ROOT="/nacl_sdk/pepper_47"
    12 TARBALL="$1"
    13 if [ -z $1 ]; then
    14     TARBALL=sdl-nacl.tar.xz
    15 fi
    17 OSTYPE=`uname -s`
    18 if [ "$OSTYPE" != "Linux" ]; then
    19     # !!! FIXME
    20     echo "This only works on x86 or x64-64 Linux at the moment." 1>&2
    21     exit 1
    22 fi
    24 if [ "x$MAKE" == "x" ]; then
    25     NCPU=`cat /proc/cpuinfo |grep vendor_id |wc -l`
    26     let NCPU=$NCPU+1
    27     MAKE="make -j$NCPU"
    28 fi
    30 BUILDBOTDIR="nacl-buildbot"
    33 set -e
    34 set -x
    35 rm -f $TARBALL
    36 rm -rf $BUILDBOTDIR
    37 mkdir -p $BUILDBOTDIR
    38 pushd $BUILDBOTDIR
    40 # !!! FIXME: ccache?
    41 export CC="$NACL_SDK_ROOT/toolchain/linux_pnacl/bin/pnacl-clang"
    42 export CFLAGS="$CFLAGS -I$NACL_SDK_ROOT/include -I$NACL_SDK_ROOT/include/pnacl"
    43 export AR="$NACL_SDK_ROOT/toolchain/linux_pnacl/bin/pnacl-ar"
    44 export LD="$NACL_SDK_ROOT/toolchain/linux_pnacl/bin/pnacl-ar"
    45 export RANLIB="$NACL_SDK_ROOT/toolchain/linux_pnacl/bin/pnacl-ranlib"
    47 ../configure --host=pnacl --prefix=$PWD/nacl-sdl2-installed
    48 $MAKE
    49 $MAKE install
    50 # Fix up a few things to a real install path
    51 perl -w -pi -e "s#$PWD/nacl-sdl2-installed#/usr/local#g;" ./nacl-sdl2-installed/lib/ ./nacl-sdl2-installed/lib/pkgconfig/sdl2.pc ./nacl-sdl2-installed/bin/sdl2-config
    52 mkdir -p ./usr
    53 mv ./nacl-sdl2-installed ./usr/local
    55 popd
    56 tar -cJvvf $TARBALL -C $BUILDBOTDIR usr
    57 rm -rf $BUILDBOTDIR
    59 set +x
    60 echo "All done. Final installable is in $TARBALL ...";