author Sam Lantinga
Fri, 27 Jan 2017 21:23:27 -0800
changeset 10861 71d8f9afb690
parent 10737 3406a0f8b041
child 11339 a6da0a386f68
permissions -rw-r--r--
Fixed bug 3569 - GL_UpdateViewport leaves PROJECTION matrix selected

Tom Seddon

GL_ActivateRenderer may call GL_UpdateViewport, which leaves the GL_PROJECTION matrix selected. But after GL_ResetState, the GL_MODELVIEW matrix is selected, suggesting that's the intended default state.

It seems at least like these should be consistent. Presumably GL_UpdateViewport should be doing a glMatrixMode(GL_MODELVIEW) before it finishes.
     1 /*
     2   Simple DirectMedia Layer
     3   Copyright (C) 1997-2017 Sam Lantinga <>
     5   This software is provided 'as-is', without any express or implied
     6   warranty.  In no event will the authors be held liable for any damages
     7   arising from the use of this software.
     9   Permission is granted to anyone to use this software for any purpose,
    10   including commercial applications, and to alter it and redistribute it
    11   freely, subject to the following restrictions:
    13   1. The origin of this software must not be misrepresented; you must not
    14      claim that you wrote the original software. If you use this software
    15      in a product, an acknowledgment in the product documentation would be
    16      appreciated but is not required.
    17   2. Altered source versions must be plainly marked as such, and must not be
    18      misrepresented as being the original software.
    19   3. This notice may not be removed or altered from any source distribution.
    20 */
    22 #ifndef SDL_dynapi_h_
    23 #define SDL_dynapi_h_
    25 /* IMPORTANT:
    26    This is the master switch to disabling the dynamic API. We made it so you
    27    have to hand-edit an internal source file in SDL to turn it off; you
    28    can do it if you want it badly enough, but hopefully you won't want to.
    29    You should understand the ramifications of turning this off: it makes it
    30    hard to update your SDL in the field, and impossible if you've statically
    31    linked SDL into your app. Understand that platforms change, and if we can't
    32    drop in an updated SDL, your application can definitely break some time
    33    in the future, even if it's fine today.
    34    To be sure, as new system-level video and audio APIs are introduced, an
    35    updated SDL can transparently take advantage of them, but your program will
    36    not without this feature. Think hard before turning it off.
    37 */
    38 #ifdef SDL_DYNAMIC_API  /* Tried to force it on the command line? */
    39 #error Nope, you have to edit this file to force this off.
    40 #endif
    42 #ifdef __APPLE__
    43 #include "TargetConditionals.h"
    44 #endif
    46 #if defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE  /* probably not useful on iOS. */
    47 #define SDL_DYNAMIC_API 0
    48 #elif defined(__native_client__) && __native_client__  /* probably not useful on NACL. */
    49 #define SDL_DYNAMIC_API 0
    50 #elif defined(__EMSCRIPTEN__) && __EMSCRIPTEN__  /* probably not useful on Emscripten. */
    51 #define SDL_DYNAMIC_API 0
    52 #elif defined(SDL_BUILDING_WINRT) && SDL_BUILDING_WINRT  /* probably not useful on WinRT, given current .dll loading restrictions */
    53 #define SDL_DYNAMIC_API 0
    54 #elif defined(__PSP__) && __PSP__
    55 #define SDL_DYNAMIC_API 0
    56 #elif defined(__clang_analyzer__)
    57 #define SDL_DYNAMIC_API 0  /* Turn off for static analysis, so reports are more clear. */
    58 #endif
    60 /* everyone else. This is where we turn on the API if nothing forced it off. */
    61 #ifndef SDL_DYNAMIC_API
    62 #define SDL_DYNAMIC_API 1
    63 #endif
    65 #endif
    67 /* vi: set ts=4 sw=4 expandtab: */