author Sam Lantinga <>
Tue, 02 Apr 2013 07:57:37 -0700
changeset 7045 4be2c24b7de1
parent 6571 bbf4d53d9e37
permissions -rw-r--r--
Fixed bug 1780 - SDL_RWFromFile() sets an error on Android although a valid SDL_RWops pointer is returned.

Philipp Wiesemann

SDL_RWFromFile() sets an error to be queried with SDL_GetError() on Android although a valid SDL_RWops pointer is returned.

This happens if the fallback implemented in SDL_android.cpp is used to load compressed assets (see in section "Loading assets") and results in a message like " This file can not be opened as a file descriptor; it is probably compressed". I think this is confusing and not needed because the loading works as expected.

I attached a patch which changes SDL_android.cpp to not set an error if compressed assets are loaded. In this case also no Exception is queried and no additional string are created.
     1 2.0 release checklist:
     2  *
     4  * See why windows are being rearranged.  Is the shield window not up?
     5  * Make sure you can create and show a fullscreen window in one step
     6  * Write automated test case for multi-draw APIs
     7  * Implement assertion code on iPhone
     8  * Add __WINDOWS__ in addition to __WIN32__
     9  * Write test for fullscreen gamma to check X11 colormap handling
    11  * Check 1.2 revisions:
    12 	3554 - Need to resolve semantics for locking keys on different platforms
    13 	4874 - Do we want screen rotation?  At what level?
    14 	4974 - Windows file code needs to convert UTF-8 to Unicode, but we don't need to tap dance for Windows 95/98
    15 	4484, 4485 - Verify that SDL's Windows keyboard handling works correctly
    16 	4865 - See if this is still needed (mouse coordinate clamping)
    17 	4866 - See if this is still needed (blocking window repositioning)