visualtest/Makefile.in
author Ryan C. Gordon
Mon, 01 Jan 2018 19:16:51 -0500
changeset 11803 454f6dc9cb85
parent 7924 fcb86d323770
permissions -rwxr-xr-x
windows: Remove references to GetVersionExA (thanks, Andrew Pilley!).

"GetVersionExA is deprecated in windows 8.1 and above's SDK, causing a warning
when building against the win10 SDK. Attached patch cleans up the usage for a
warning-free build.

GetVersionExA was being used to test to see if SDL was running on win9x or
winnt. A quick chat with Ryan on twitter suggested that SDL doesn't
officially support win9x anymore, so the call to this can be outright removed.

As an aside, replacing the call to GetVersionExA with VerifyVersionInfoA (the
recommended path) would have been pointless, as VerifyVersionInfoA only
supports VER_PLATFORM_WIN32_NT and doesn't officially support any other value
for dwPlatformId currently. (And it's probable that win9x SDKs didn't have
VerifyVersionInfo* in them anyway.)"

Fixes Bugzilla #4019.
     1 # Makefile to build the SDL tests
     2 srcdir  = @srcdir@
     3 CC      = @CC@
     4 EXE	= @EXE@
     5 CFLAGS  = @CFLAGS@ -I../include -I./include
     6 LIBS	= @LIBS@
     7 TARGETS = \
     8 	testharness$(EXE) \
     9 	testquit$(EXE)
    10 all: Makefile $(TARGETS)
    11 Makefile: $(srcdir)/Makefile.in
    12 	$(SHELL) config.status $@
    13 testharness$(EXE): $(srcdir)/src/action_configparser.c \
    14 		   $(srcdir)/src/harness_argparser.c \
    15 		   $(srcdir)/src/rwhelper.c \
    16 		   $(srcdir)/src/testharness.c \
    17 		   $(srcdir)/src/variator_exhaustive.c \
    18 		   $(srcdir)/src/variators.c \
    19 		   $(srcdir)/src/screenshot.c \
    20 		   $(srcdir)/src/harness_argparser.c \
    21 		   $(srcdir)/src/sut_configparser.c \
    22 		   $(srcdir)/src/variator_common.c \
    23 		   $(srcdir)/src/variator_random.c \
    24 		   $(srcdir)/src/parsehelper.c \
    25 		   $(srcdir)/src/mischelper.c \
    26 		   $(srcdir)/src/linux/linux_process.c \
    27 		   $(srcdir)/src/windows/windows_process.c \
    28 		   $(srcdir)/src/windows/windows_screenshot.c
    29 	$(CC) -o $@ $^ $(CFLAGS) $(LIBS)
    30 testquit$(EXE): $(srcdir)/unittest/testquit.c
    31 	$(CC) -o $@ $^ $(CFLAGS) $(LIBS)
    32 clean:
    33 	rm -f $(TARGETS)
    34 distclean: clean
    35 	rm -f Makefile
    36 	rm -f config.status config.cache config.log
    37 	rm -rf $(srcdir)/autom4te*