src/dynapi/SDL_dynapi.h
author Ryan C. Gordon
Mon, 01 Jan 2018 19:16:51 -0500
changeset 11803 454f6dc9cb85
parent 11358 c3d73a93d635
child 11811 5d94cb6b24d3
permissions -rw-r--r--
windows: Remove references to GetVersionExA (thanks, Andrew Pilley!).

"GetVersionExA is deprecated in windows 8.1 and above's SDK, causing a warning
when building against the win10 SDK. Attached patch cleans up the usage for a
warning-free build.

GetVersionExA was being used to test to see if SDL was running on win9x or
winnt. A quick chat with Ryan on twitter suggested that SDL doesn't
officially support win9x anymore, so the call to this can be outright removed.

As an aside, replacing the call to GetVersionExA with VerifyVersionInfoA (the
recommended path) would have been pointless, as VerifyVersionInfoA only
supports VER_PLATFORM_WIN32_NT and doesn't officially support any other value
for dwPlatformId currently. (And it's probable that win9x SDKs didn't have
VerifyVersionInfo* in them anyway.)"

Fixes Bugzilla #4019.
     1 /*
     2   Simple DirectMedia Layer
     3   Copyright (C) 1997-2017 Sam Lantinga <slouken@libsdl.org>
     4 
     5   This software is provided 'as-is', without any express or implied
     6   warranty.  In no event will the authors be held liable for any damages
     7   arising from the use of this software.
     8 
     9   Permission is granted to anyone to use this software for any purpose,
    10   including commercial applications, and to alter it and redistribute it
    11   freely, subject to the following restrictions:
    12 
    13   1. The origin of this software must not be misrepresented; you must not
    14      claim that you wrote the original software. If you use this software
    15      in a product, an acknowledgment in the product documentation would be
    16      appreciated but is not required.
    17   2. Altered source versions must be plainly marked as such, and must not be
    18      misrepresented as being the original software.
    19   3. This notice may not be removed or altered from any source distribution.
    20 */
    21 
    22 #ifndef SDL_dynapi_h_
    23 #define SDL_dynapi_h_
    24 
    25 /* IMPORTANT:
    26    This is the master switch to disabling the dynamic API. We made it so you
    27    have to hand-edit an internal source file in SDL to turn it off; you
    28    can do it if you want it badly enough, but hopefully you won't want to.
    29    You should understand the ramifications of turning this off: it makes it
    30    hard to update your SDL in the field, and impossible if you've statically
    31    linked SDL into your app. Understand that platforms change, and if we can't
    32    drop in an updated SDL, your application can definitely break some time
    33    in the future, even if it's fine today.
    34    To be sure, as new system-level video and audio APIs are introduced, an
    35    updated SDL can transparently take advantage of them, but your program will
    36    not without this feature. Think hard before turning it off.
    37 */
    38 #ifdef SDL_DYNAMIC_API  /* Tried to force it on the command line? */
    39 #error Nope, you have to edit this file to force this off.
    40 #endif
    41 
    42 #ifdef __APPLE__
    43 #include "TargetConditionals.h"
    44 #endif
    45 
    46 #if defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE  /* probably not useful on iOS. */
    47 #define SDL_DYNAMIC_API 0
    48 #elif defined(__native_client__) && __native_client__  /* probably not useful on NACL. */
    49 #define SDL_DYNAMIC_API 0
    50 #elif defined(__EMSCRIPTEN__) && __EMSCRIPTEN__  /* probably not useful on Emscripten. */
    51 #define SDL_DYNAMIC_API 0
    52 #elif defined(SDL_BUILDING_WINRT) && SDL_BUILDING_WINRT  /* probably not useful on WinRT, given current .dll loading restrictions */
    53 #define SDL_DYNAMIC_API 0
    54 #elif defined(__PSP__) && __PSP__
    55 #define SDL_DYNAMIC_API 0
    56 #elif defined(__clang_analyzer__)
    57 #define SDL_DYNAMIC_API 0  /* Turn off for static analysis, so reports are more clear. */
    58 #endif
    59 
    60 /* everyone else. This is where we turn on the API if nothing forced it off. */
    61 #ifndef SDL_DYNAMIC_API
    62 #define SDL_DYNAMIC_API 1
    63 #endif
    64 
    65 #endif
    66 
    67 /* vi: set ts=4 sw=4 expandtab: */