author Ryan C. Gordon
Mon, 01 Jan 2018 19:16:51 -0500
changeset 11803 454f6dc9cb85
parent 11726 27d08f1aab80
child 11811 5d94cb6b24d3
permissions -rw-r--r--
windows: Remove references to GetVersionExA (thanks, Andrew Pilley!).

"GetVersionExA is deprecated in windows 8.1 and above's SDK, causing a warning
when building against the win10 SDK. Attached patch cleans up the usage for a
warning-free build.

GetVersionExA was being used to test to see if SDL was running on win9x or
winnt. A quick chat with Ryan on twitter suggested that SDL doesn't
officially support win9x anymore, so the call to this can be outright removed.

As an aside, replacing the call to GetVersionExA with VerifyVersionInfoA (the
recommended path) would have been pointless, as VerifyVersionInfoA only
supports VER_PLATFORM_WIN32_NT and doesn't officially support any other value
for dwPlatformId currently. (And it's probable that win9x SDKs didn't have
VerifyVersionInfo* in them anyway.)"

Fixes Bugzilla #4019.
     1 /*
     2   Simple DirectMedia Layer
     3   Copyright (C) 1997-2017 Sam Lantinga <>
     5   This software is provided 'as-is', without any express or implied
     6   warranty.  In no event will the authors be held liable for any damages
     7   arising from the use of this software.
     9   Permission is granted to anyone to use this software for any purpose,
    10   including commercial applications, and to alter it and redistribute it
    11   freely, subject to the following restrictions:
    13   1. The origin of this software must not be misrepresented; you must not
    14      claim that you wrote the original software. If you use this software
    15      in a product, an acknowledgment in the product documentation would be
    16      appreciated but is not required.
    17   2. Altered source versions must be plainly marked as such, and must not be
    18      misrepresented as being the original software.
    19   3. This notice may not be removed or altered from any source distribution.
    20 */
    21 #ifndef SDL_internal_h_
    22 #define SDL_internal_h_
    24 /* Many of SDL's features require _GNU_SOURCE on various platforms */
    25 #ifndef _GNU_SOURCE
    26 #define _GNU_SOURCE
    27 #endif
    29 /* This is for a variable-length array at the end of a struct:
    30     struct x { int y; char z[SDL_VARIABLE_LENGTH_ARRAY]; };
    31    Use this because GCC 2 needs different magic than other compilers. */
    32 #if (defined(__GNUC__) && (__GNUC__ <= 2)) || defined(__CC_ARM) || defined(__cplusplus)
    34 #else
    36 #endif
    38 #include "dynapi/SDL_dynapi.h"
    40 #if SDL_DYNAMIC_API
    41 #include "dynapi/SDL_dynapi_overrides.h"
    42 /* force DECLSPEC and SDLCALL's all internal symbols now.
    43    These will have actual #defines during SDL_dynapi.c only */
    44 #define DECLSPEC
    45 #define SDLCALL
    46 #endif
    48 #include "SDL_config.h"
    50 #endif /* SDL_internal_h_ */
    52 /* vi: set ts=4 sw=4 expandtab: */