test/testtypes.c
author Patrice Mandin <patmandin@gmail.com>
Thu, 19 Jan 2006 21:28:52 +0000
changeset 1257 448a9a64537b
parent 1154 d93862a3d821
child 1387 835c1831f903
permissions -rw-r--r--
[PATCH] SDL_GetVideoMode() does not find best mode, part 2

Following commit 1.51, I come accross a problem when SDL must choose between
several video modes that could suit the one asked.

If I ask 320x240 with this list:
768x480 768x240 640x400 640x200 384x480 384x240 320x400 320x200

The smallest selectables modes are 384x240 and 320x400. And SDL choose the later
in this list, but 384x240 is more suitable. So I added a check to compare
the pixel count (surface) of modes, and select the one which has the smallest
pixel count.

In my example, 384x240 has 92160 pixels, and 320x400 has 128000 pixels. So now
SDL will choose 384x240 for the asked 320x240 mode.
     1 
     2 #include <stdio.h>
     3 #include <stdlib.h>
     4 #include <string.h>
     5 #include "SDL_main.h"
     6 #include "SDL_types.h"
     7 
     8 /*
     9  * Watcom C flags these as Warning 201: "Unreachable code" if you just
    10  *  compare them directly, so we push it through a function to keep the
    11  *  compiler quiet.  --ryan.
    12  */
    13 static int badsize(size_t sizeoftype, size_t hardcodetype)
    14 {
    15     return sizeoftype != hardcodetype;
    16 }
    17 
    18 int main(int argc, char *argv[])
    19 {
    20 	int error = 0;
    21 	int verbose = 1;
    22 
    23 	if ( argv[1] && (strcmp(argv[1], "-q") == 0) )
    24 		verbose = 0;
    25 
    26 	if ( badsize(sizeof(Uint8), 1) ) {
    27 		if ( verbose )
    28 			printf("sizeof(Uint8) != 1, instead = %d\n",
    29 								sizeof(Uint8));
    30 		++error;
    31 	}
    32 	if ( badsize(sizeof(Uint16), 2) ) {
    33 		if ( verbose )
    34 			printf("sizeof(Uint16) != 2, instead = %d\n",
    35 								sizeof(Uint16));
    36 		++error;
    37 	}
    38 	if ( badsize(sizeof(Uint32), 4) ) {
    39 		if ( verbose )
    40 			printf("sizeof(Uint32) != 4, instead = %d\n",
    41 								sizeof(Uint32));
    42 		++error;
    43 	}
    44 #ifdef SDL_HAS_64BIT_TYPE
    45 	if ( badsize(sizeof(Uint64), 8) ) {
    46 		if ( verbose )
    47 			printf("sizeof(Uint64) != 8, instead = %d\n",
    48 								sizeof(Uint64));
    49 		++error;
    50 	}
    51 #else
    52 	if ( verbose ) {
    53 		printf("WARNING: No 64-bit datatype on this platform\n");
    54 	}
    55 #endif
    56 	if ( verbose && ! error )
    57 		printf("All data types are the expected size.\n");
    58 
    59 	return( error ? 1 : 0 );
    60 }