author Ryan C. Gordon <>
Thu, 28 May 2015 01:54:52 -0400
changeset 9671 0e1f57b051f4
parent 7856 cb37776926ad
permissions -rw-r--r--
Windows GetBasePath should use GetModuleFileNameExW() and check for overflows.

Apparently you might get strange paths from GetModuleFileName(), such as
short path names or UNC filenames, so this avoids that problem. Since you have
to tapdance with linking different libraries and defining macros depending on
what Windows you plan to target, we dynamically load the API we need, which
works on all versions of Windows (on Win7, it'll load a compatibility wrapper
for the newer API location).

What a mess.

This also now does the right thing if there isn't enough space to store the
path, looping with a larger allocated buffer each try.

Fixes Bugzilla #2435.
     1 Future work roadmap:
     2  *
     4  * Check 1.2 revisions:
     5 	3554 - Need to resolve semantics for locking keys on different platforms
     6 	4874 - Do we want screen rotation?  At what level?
     7 	4974 - Windows file code needs to convert UTF-8 to Unicode, but we don't need to tap dance for Windows 95/98
     8 	4865 - See if this is still needed (mouse coordinate clamping)
     9 	4866 - See if this is still needed (blocking window repositioning)