Makefile.pandora
author Sam Lantinga <slouken@libsdl.org>
Fri, 28 Nov 2014 04:51:33 -0800
changeset 9246 a761913e5e91
parent 7667 be1cc6f55840
child 10203 ed1bad553a56
permissions -rw-r--r--
Fixed bug 2786 - "UCS-2-INTERNAL" iconv encoding is not supported everywhere, use UTF-16LE instead

Jonas Kulla

src/main/windows/SDL_windows_main.c:137:
cmdline = SDL_iconv_string("UTF-8", "UCS-2-INTERNAL", (char *)(text), (SDL_wcslen(text)+1)*sizeof(WCHAR));

I'm trying to compile an SDL2 application for windows using the mingw-w64 32bit toolchain provided by my distro (Fedora 19). However, even the simplest test program that does nothing at all fails to startup with a "Fatal error - out of memory" message because the mingw iconv library provided by my distro does not support the "UCS-2-INTERNAL" encoding and the conversion returns null.

From my little bit of research, it turns out that even though this encoding is supported by the external GNU libiconv library, some glibc versions (?) don't support it with their internal iconv routines, and will instead provide the native endian encoding when "UCS-2" is specified.

Nonetheless, I wonder why the native endianness is considered in the first place when Windows doesn't even run on any big endian archs (to my knowledge). And true enough, 'WIN_StringToUTF8' from core/windows/SDL_windows.h is used everywhere else in the windows backend, which is just a macro to iconv with "UTF-16LE" as source. Therefore it would IMO make sense to use this macro here as well, which would solve my problem (patch attached).
slouken@3161
     1
# Makefile to build the pandora SDL library
slouken@3161
     2
slouken@3161
     3
AR	= arm-none-linux-gnueabi-ar
slouken@3161
     4
RANLIB	= arm-none-linux-gnueabi-ranlib
slouken@3161
     5
CC = arm-none-linux-gnueabi-gcc
slouken@3161
     6
CXX = arm-none-linux-gnueabi-g++
slouken@3161
     7
STRIP = arm-none-linux-gnueabi-strip
slouken@3161
     8
slouken@3161
     9
CFLAGS  = -O3 -march=armv7-a -mcpu=cortex-a8 -mtune=cortex-a8 -mfloat-abi=softfp \
slouken@3161
    10
	-mfpu=neon -ftree-vectorize -ffast-math -fomit-frame-pointer -fno-strict-aliasing -fsingle-precision-constant \
slouken@3218
    11
	-I./include -I$(PNDSDK)/usr/include -DSDL_REVISION=0
slouken@3161
    12
slouken@3161
    13
TARGET  = libSDL.a
slouken@3161
    14
slouken@4471
    15
SOURCES = ./src/*.c ./src/audio/*.c ./src/cpuinfo/*.c ./src/events/*.c \
slouken@3161
    16
	./src/file/*.c ./src/stdlib/*.c ./src/thread/*.c ./src/timer/*.c ./src/video/*.c \
icculus@3170
    17
	./src/joystick/*.c ./src/haptic/*.c ./src/power/*.c ./src/video/dummy/*.c ./src/audio/disk/*.c \
icculus@5586
    18
	./src/audio/dummy/*.c ./src/loadso/dlopen/*.c ./src/audio/dsp/*.c \
slouken@3161
    19
	./src/thread/pthread/SDL_systhread.c ./src/thread/pthread/SDL_syssem.c \
slouken@3161
    20
	./src/thread/pthread/SDL_sysmutex.c ./src/thread/pthread/SDL_syscond.c \
slouken@4471
    21
	./src/joystick/linux/*.c ./src/haptic/linux/*.c ./src/timer/unix/*.c \
icculus@7667
    22
	./src/atomic/linux/*.c ./src/filesystem/unix/*.c \
slouken@4471
    23
	./src/video/pandora/SDL_pandora.o ./src/video/pandora/SDL_pandora_events.o ./src/video/x11/*.c 
slouken@3161
    24
	
slouken@3161
    25
slouken@3161
    26
OBJECTS = $(shell echo $(SOURCES) | sed -e 's,\.c,\.o,g')
slouken@3161
    27
slouken@3218
    28
CONFIG_H = $(shell cp include/SDL_config_pandora.h include/SDL_config.h && touch include/SDL_revision.h)
slouken@3218
    29
slouken@3161
    30
all: $(TARGET)
slouken@3161
    31
slouken@3161
    32
$(TARGET): $(CONFIG_H) $(OBJECTS)
slouken@3161
    33
	$(AR) crv $@ $^
slouken@3161
    34
	$(RANLIB) $@
slouken@3161
    35
slouken@3161
    36
clean:
slouken@3161
    37
	rm -f $(TARGET) $(OBJECTS)