COPYING.txt
author Sam Lantinga <slouken@libsdl.org>
Fri, 28 Nov 2014 04:51:33 -0800
changeset 9246 a761913e5e91
parent 8149 681eb46b8ac4
child 9619 b94b6d0bff0f
permissions -rw-r--r--
Fixed bug 2786 - "UCS-2-INTERNAL" iconv encoding is not supported everywhere, use UTF-16LE instead

Jonas Kulla

src/main/windows/SDL_windows_main.c:137:
cmdline = SDL_iconv_string("UTF-8", "UCS-2-INTERNAL", (char *)(text), (SDL_wcslen(text)+1)*sizeof(WCHAR));

I'm trying to compile an SDL2 application for windows using the mingw-w64 32bit toolchain provided by my distro (Fedora 19). However, even the simplest test program that does nothing at all fails to startup with a "Fatal error - out of memory" message because the mingw iconv library provided by my distro does not support the "UCS-2-INTERNAL" encoding and the conversion returns null.

From my little bit of research, it turns out that even though this encoding is supported by the external GNU libiconv library, some glibc versions (?) don't support it with their internal iconv routines, and will instead provide the native endian encoding when "UCS-2" is specified.

Nonetheless, I wonder why the native endianness is considered in the first place when Windows doesn't even run on any big endian archs (to my knowledge). And true enough, 'WIN_StringToUTF8' from core/windows/SDL_windows.h is used everywhere else in the windows backend, which is just a macro to iconv with "UTF-16LE" as source. Therefore it would IMO make sense to use this macro here as well, which would solve my problem (patch attached).
slouken@7222
     1
slouken@7222
     2
Simple DirectMedia Layer
slouken@8149
     3
Copyright (C) 1997-2014 Sam Lantinga <slouken@libsdl.org>
slouken@7222
     4
  
slouken@7222
     5
This software is provided 'as-is', without any express or implied
slouken@7222
     6
warranty.  In no event will the authors be held liable for any damages
slouken@7222
     7
arising from the use of this software.
slouken@7222
     8
slouken@7222
     9
Permission is granted to anyone to use this software for any purpose,
slouken@7222
    10
including commercial applications, and to alter it and redistribute it
slouken@7222
    11
freely, subject to the following restrictions:
slouken@7222
    12
  
slouken@7222
    13
1. The origin of this software must not be misrepresented; you must not
slouken@7222
    14
   claim that you wrote the original software. If you use this software
slouken@7222
    15
   in a product, an acknowledgment in the product documentation would be
slouken@7222
    16
   appreciated but is not required. 
slouken@7222
    17
2. Altered source versions must be plainly marked as such, and must not be
slouken@7222
    18
   misrepresented as being the original software.
slouken@7222
    19
3. This notice may not be removed or altered from any source distribution.
slouken@7222
    20