debian/rules
author Ryan C. Gordon
Mon, 21 Aug 2017 00:42:06 -0400
changeset 11334 749cb40916f2
parent 7906 19f5760dc1a7
child 12402 3b5b4eb1927f
permissions -rwxr-xr-x
x11: specify event mask for buttons when grabbing pointer (thanks, Stas!).

This fixes a strange corner case (notes appended below), and should be
safe to do anyhow.

Fixes Bugzilla #3674.

"I did more tests.
It appears the bug only happens if there is
another window on the screen that has "always
on top" property. For me it is xawtv - it is
always opened in a screen corner. Closing
xawtv or removing "always on top" property
from it makes the problem to go away.
Plus, it doesn't appear like the buttons are
not delivered at all. It appears that instead
the button presses are delivered on some mouse
positions, but not delivered when you move the
mouse to other part of the window... So this is
really weird and is likely somewhere deep in the
Xorg.
Maybe somehow it happens that the cursor is
actually above the xawtv window, but, because
my app uses grab, it is not visible there, and
in that case the events are not delivered to
my app?
But with my patch the button events are
always delivered flawlessly, it seems.

Hmm, and that indeed seems to explain my problem:
if the mask is set properly and my app uses
grab, then, even if the mouse is above some
other window, the events would still be delivered
to the grabbing app, which is what actually wanted
because my app uses relative mouse mode, so it
doesn't know the pointer can cross some other window
(my app draws the pointer itself).
So my current theory is that my patch only enforces
the mouse grab, which otherwise can be tricked by
some other window preventing the button events
delivery (but motion events are still delivered
via xinput2, which makes it all look very obscure)."
slouken@6886
     1
#!/usr/bin/make -f
slouken@6886
     2
slouken@6886
     3
DEB_HOST_ARCH_CPU ?= $(shell dpkg-architecture -qDEB_HOST_ARCH_CPU)
slouken@6886
     4
DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH)
slouken@6886
     5
slouken@6889
     6
confflags = --disable-rpath --disable-video-directfb \
slouken@6889
     7
            --disable-nas --disable-esd --disable-arts \
slouken@6889
     8
            --disable-alsa-shared --disable-pulseaudio-shared \
slouken@6889
     9
            --disable-x11-shared
slouken@6886
    10
slouken@6886
    11
%:
slouken@6886
    12
	dh $@ --parallel
slouken@6886
    13
slouken@6886
    14
override_dh_auto_configure:
slouken@6886
    15
	dh_auto_configure -Bbuilddir/all -- $(confflags)
slouken@6886
    16
slouken@6886
    17
override_dh_auto_build:
slouken@6886
    18
	dh_auto_build -Bbuilddir/all
slouken@6886
    19
	tar czf debian/examples.tar.gz test
slouken@6886
    20
slouken@6886
    21
override_dh_auto_install:
slouken@6886
    22
	dh_auto_install -Bbuilddir/all
slouken@6886
    23
slouken@6886
    24
override_dh_auto_clean:
slouken@6886
    25
	dh_auto_clean -Bbuilddir/all
slouken@6886
    26
	rm -f debian/examples.tar.gz
slouken@6886
    27
slouken@6886
    28
override_dh_install:
slouken@6886
    29
	dh_install --remaining-packages --fail-missing -XlibSDL2.la
slouken@6886
    30
slouken@6886
    31
override_dh_installexamples:
slouken@6886
    32
	dh_installexamples -plibsdl2-dev debian/examples.tar.gz
slouken@6886
    33
	dh_installexamples --remaining-packages
slouken@6886
    34
slouken@6886
    35
override_dh_link:
slouken@7906
    36
	# to address lintian warning
slouken@7906
    37
	# W: libsdl2-2.0-0: dev-pkg-without-shlib-symlink usr/lib/x86_64-linux-gnu/libSDL2-2.0.so.0.0.0 usr/lib/x86_64-linux-gnu/libSDL2-2.0.so
slouken@6886
    38
	dh_link -plibsdl2-dev usr/lib/$(DEB_HOST_MULTIARCH)/libSDL2-2.0.so.0.0.0 usr/lib/$(DEB_HOST_MULTIARCH)/libSDL2-2.0.so
slouken@6886
    39
slouken@6886
    40
override_dh_strip:
slouken@6886
    41
	dh_strip --dbg-package=libsdl2-dbg