build-scripts/updaterev.sh
author Ryan C. Gordon
Mon, 21 Aug 2017 00:42:06 -0400
changeset 11334 749cb40916f2
parent 6994 06f368666c6f
permissions -rwxr-xr-x
x11: specify event mask for buttons when grabbing pointer (thanks, Stas!).

This fixes a strange corner case (notes appended below), and should be
safe to do anyhow.

Fixes Bugzilla #3674.

"I did more tests.
It appears the bug only happens if there is
another window on the screen that has "always
on top" property. For me it is xawtv - it is
always opened in a screen corner. Closing
xawtv or removing "always on top" property
from it makes the problem to go away.
Plus, it doesn't appear like the buttons are
not delivered at all. It appears that instead
the button presses are delivered on some mouse
positions, but not delivered when you move the
mouse to other part of the window... So this is
really weird and is likely somewhere deep in the
Xorg.
Maybe somehow it happens that the cursor is
actually above the xawtv window, but, because
my app uses grab, it is not visible there, and
in that case the events are not delivered to
my app?
But with my patch the button events are
always delivered flawlessly, it seems.

Hmm, and that indeed seems to explain my problem:
if the mask is set properly and my app uses
grab, then, even if the mouse is above some
other window, the events would still be delivered
to the grabbing app, which is what actually wanted
because my app uses relative mouse mode, so it
doesn't know the pointer can cross some other window
(my app draws the pointer itself).
So my current theory is that my patch only enforces
the mouse grab, which otherwise can be tricked by
some other window preventing the button events
delivery (but motion events are still delivered
via xinput2, which makes it all look very obscure)."
slouken@2982
     1
#!/bin/sh
slouken@2982
     2
#
slouken@2982
     3
# Generate a header file with the current source revision
slouken@2982
     4
slouken@5310
     5
outdir=`pwd`
slouken@2982
     6
cd `dirname $0`
slouken@2982
     7
srcdir=..
slouken@5310
     8
header=$outdir/include/SDL_revision.h
slouken@2982
     9
slouken@5345
    10
rev=`sh showrev.sh 2>/dev/null`
slouken@4936
    11
if [ "$rev" != "" -a "$rev" != "hg-0:baadf00d" ]; then
slouken@5359
    12
    revnum=`echo $rev | sed 's,hg-\([0-9]*\).*,\1,'`
aschiffler@6994
    13
    echo "#define SDL_REVISION \"$rev\"" >"$header.new"
aschiffler@6994
    14
    echo "#define SDL_REVISION_NUMBER $revnum" >>"$header.new"
slouken@2982
    15
    if diff $header $header.new >/dev/null 2>&1; then
aschiffler@6994
    16
        rm "$header.new"
slouken@2982
    17
    else
aschiffler@6994
    18
        mv "$header.new" "$header"
slouken@2982
    19
    fi
slouken@2982
    20
fi