COPYING.txt
author Ryan C. Gordon
Mon, 21 Aug 2017 00:42:06 -0400
changeset 11334 749cb40916f2
parent 10737 3406a0f8b041
child 11811 5d94cb6b24d3
permissions -rw-r--r--
x11: specify event mask for buttons when grabbing pointer (thanks, Stas!).

This fixes a strange corner case (notes appended below), and should be
safe to do anyhow.

Fixes Bugzilla #3674.

"I did more tests.
It appears the bug only happens if there is
another window on the screen that has "always
on top" property. For me it is xawtv - it is
always opened in a screen corner. Closing
xawtv or removing "always on top" property
from it makes the problem to go away.
Plus, it doesn't appear like the buttons are
not delivered at all. It appears that instead
the button presses are delivered on some mouse
positions, but not delivered when you move the
mouse to other part of the window... So this is
really weird and is likely somewhere deep in the
Xorg.
Maybe somehow it happens that the cursor is
actually above the xawtv window, but, because
my app uses grab, it is not visible there, and
in that case the events are not delivered to
my app?
But with my patch the button events are
always delivered flawlessly, it seems.

Hmm, and that indeed seems to explain my problem:
if the mask is set properly and my app uses
grab, then, even if the mouse is above some
other window, the events would still be delivered
to the grabbing app, which is what actually wanted
because my app uses relative mouse mode, so it
doesn't know the pointer can cross some other window
(my app draws the pointer itself).
So my current theory is that my patch only enforces
the mouse grab, which otherwise can be tricked by
some other window preventing the button events
delivery (but motion events are still delivered
via xinput2, which makes it all look very obscure)."
slouken@7222
     1
slouken@7222
     2
Simple DirectMedia Layer
slouken@10737
     3
Copyright (C) 1997-2017 Sam Lantinga <slouken@libsdl.org>
slouken@7222
     4
  
slouken@7222
     5
This software is provided 'as-is', without any express or implied
slouken@7222
     6
warranty.  In no event will the authors be held liable for any damages
slouken@7222
     7
arising from the use of this software.
slouken@7222
     8
slouken@7222
     9
Permission is granted to anyone to use this software for any purpose,
slouken@7222
    10
including commercial applications, and to alter it and redistribute it
slouken@7222
    11
freely, subject to the following restrictions:
slouken@7222
    12
  
slouken@7222
    13
1. The origin of this software must not be misrepresented; you must not
slouken@7222
    14
   claim that you wrote the original software. If you use this software
slouken@7222
    15
   in a product, an acknowledgment in the product documentation would be
slouken@7222
    16
   appreciated but is not required. 
slouken@7222
    17
2. Altered source versions must be plainly marked as such, and must not be
slouken@7222
    18
   misrepresented as being the original software.
slouken@7222
    19
3. This notice may not be removed or altered from any source distribution.
slouken@7222
    20