COPYING.txt
author Sam Lantinga <slouken@libsdl.org>
Tue, 25 Sep 2018 20:08:51 -0700
changeset 12224 0582b4e1fa9f
parent 11811 5d94cb6b24d3
child 12503 806492103856
permissions -rw-r--r--
Fixed bug 4268 - Android_JNI_OpenAudioDevice function has error

alittle

where iscapture == 1

1.param set error

(*env)->CallStaticIntMethod(env, mAudioManagerClass, midCaptureOpen, sampleRate, audioBuffer16Bit, audioBufferStereo, desiredBufferFrames)

param:audioBuffer16Bit need change to captureBuffer16Bit

2.logic error

if (is16Bit) {
// ALITTLE Modify the source code
if (iscapture) {
audioBufferFrames = (*env)->GetArrayLength(env, (jshortArray)captureBuffer);
} else {
audioBufferPinned = (*env)->GetShortArrayElements(env, (jshortArray)audioBuffer, &isCopy);
audioBufferFrames = (*env)->GetArrayLength(env, (jshortArray)audioBuffer);
}
// if (!iscapture) {
// audioBufferPinned = (*env)->GetShortArrayElements(env, (jshortArray)audioBuffer, &isCopy);
// }
// audioBufferFrames = (*env)->GetArrayLength(env, (jshortArray)audioBuffer);
} else {
// ALITTLE Modify the source code
if (iscapture) {
audioBufferFrames = (*env)->GetArrayLength(env, (jbyteArray)captureBuffer);
} else {
audioBufferPinned = (*env)->GetByteArrayElements(env, (jbyteArray)audioBuffer, &isCopy);
audioBufferFrames = (*env)->GetArrayLength(env, (jbyteArray)audioBuffer);
}
// if (!iscapture) {
// audioBufferPinned = (*env)->GetByteArrayElements(env, (jbyteArray)audioBuffer, &isCopy);
// }
// audioBufferFrames = (*env)->GetArrayLength(env, (jbyteArray)audioBuffer);
}
slouken@7222
     1
slouken@7222
     2
Simple DirectMedia Layer
slouken@11811
     3
Copyright (C) 1997-2018 Sam Lantinga <slouken@libsdl.org>
slouken@7222
     4
  
slouken@7222
     5
This software is provided 'as-is', without any express or implied
slouken@7222
     6
warranty.  In no event will the authors be held liable for any damages
slouken@7222
     7
arising from the use of this software.
slouken@7222
     8
slouken@7222
     9
Permission is granted to anyone to use this software for any purpose,
slouken@7222
    10
including commercial applications, and to alter it and redistribute it
slouken@7222
    11
freely, subject to the following restrictions:
slouken@7222
    12
  
slouken@7222
    13
1. The origin of this software must not be misrepresented; you must not
slouken@7222
    14
   claim that you wrote the original software. If you use this software
slouken@7222
    15
   in a product, an acknowledgment in the product documentation would be
slouken@7222
    16
   appreciated but is not required. 
slouken@7222
    17
2. Altered source versions must be plainly marked as such, and must not be
slouken@7222
    18
   misrepresented as being the original software.
slouken@7222
    19
3. This notice may not be removed or altered from any source distribution.
slouken@7222
    20