BUGS.txt
author Sam Lantinga <slouken@libsdl.org>
Tue, 25 Sep 2018 20:08:51 -0700
changeset 12224 0582b4e1fa9f
parent 10952 fabcc99bb455
permissions -rw-r--r--
Fixed bug 4268 - Android_JNI_OpenAudioDevice function has error

alittle

where iscapture == 1

1.param set error

(*env)->CallStaticIntMethod(env, mAudioManagerClass, midCaptureOpen, sampleRate, audioBuffer16Bit, audioBufferStereo, desiredBufferFrames)

param:audioBuffer16Bit need change to captureBuffer16Bit

2.logic error

if (is16Bit) {
// ALITTLE Modify the source code
if (iscapture) {
audioBufferFrames = (*env)->GetArrayLength(env, (jshortArray)captureBuffer);
} else {
audioBufferPinned = (*env)->GetShortArrayElements(env, (jshortArray)audioBuffer, &isCopy);
audioBufferFrames = (*env)->GetArrayLength(env, (jshortArray)audioBuffer);
}
// if (!iscapture) {
// audioBufferPinned = (*env)->GetShortArrayElements(env, (jshortArray)audioBuffer, &isCopy);
// }
// audioBufferFrames = (*env)->GetArrayLength(env, (jshortArray)audioBuffer);
} else {
// ALITTLE Modify the source code
if (iscapture) {
audioBufferFrames = (*env)->GetArrayLength(env, (jbyteArray)captureBuffer);
} else {
audioBufferPinned = (*env)->GetByteArrayElements(env, (jbyteArray)audioBuffer, &isCopy);
audioBufferFrames = (*env)->GetArrayLength(env, (jbyteArray)audioBuffer);
}
// if (!iscapture) {
// audioBufferPinned = (*env)->GetByteArrayElements(env, (jbyteArray)audioBuffer, &isCopy);
// }
// audioBufferFrames = (*env)->GetArrayLength(env, (jbyteArray)audioBuffer);
}
slouken@7222
     1
slouken@7222
     2
Bugs are now managed in the SDL bug tracker, here:
slouken@7222
     3
icculus@10236
     4
    https://bugzilla.libsdl.org/
slouken@7222
     5
slouken@7222
     6
You may report bugs there, and search to see if a given issue has already
slouken@7222
     7
 been reported, discussed, and maybe even fixed.
slouken@7222
     8
slouken@7222
     9
icculus@10952
    10
You may also find help at the SDL forums/mailing list:
slouken@7222
    11
icculus@10952
    12
    https://discourse.libsdl.org/
slouken@7222
    13
slouken@7222
    14
Bug reports are welcome here, but we really appreciate if you use Bugzilla, as
slouken@7222
    15
 bugs discussed on the mailing list may be forgotten or missed.
slouken@7222
    16